git/http.c, branch v2.3.0

Merge branch 'da/include-compat-util-first-in-c'

2014-10-14T17:49:01Z

Code clean-up. * da/include-compat-util-first-in-c: cleanups: ensure that git-compat-util.h is included first

cleanups: ensure that git-compat-util.h is included first

2014-09-15T19:05:14Z

CodingGuidelines states that the first #include in C files should be git-compat-util.h or another header file that includes it, such as cache.h or builtin.h. Signed-off-by: David Aguilar Signed-off-by: Junio C Hamano

Merge branch 'br/http-init-fix'

2014-09-11T17:33:28Z

Code clean-up. * br/http-init-fix: http: style fixes for curl_multi_init error check http.c: die if curl_*_init fails

http: style fixes for curl_multi_init error check

2014-08-21T17:53:55Z

Unless there is a good reason, we should use die() rather than fprintf/exit. We can also shorten the message to match other curl init failures (and match our usual lowercase no-full-stop style). Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

run-command: introduce CHILD_PROCESS_INIT

2014-08-20T16:53:37Z

Most struct child_process variables are cleared using memset first after declaration. Provide a macro, CHILD_PROCESS_INIT, that can be used to initialize them statically instead. That's shorter, doesn't require a function call and is slightly more readable (especially given that we already have STRBUF_INIT, ARGV_ARRAY_INIT etc.). Helped-by: Johannes Sixt Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

http.c: die if curl_*_init fails

2014-08-18T17:11:42Z

Signed-off-by: Bernhard Reiter Reviewed-by: Jeff King Signed-off-by: Junio C Hamano

Merge branch 'jk/skip-prefix'

2014-07-09T18:33:28Z

* jk/skip-prefix: http-push: refactor parsing of remote object names imap-send: use skip_prefix instead of using magic numbers use skip_prefix to avoid repeated calculations git: avoid magic number with skip_prefix fetch-pack: refactor parsing in get_ack fast-import: refactor parsing of spaces stat_opt: check extra strlen call daemon: use skip_prefix to avoid magic numbers fast-import: use skip_prefix for parsing input use skip_prefix to avoid repeating strings use skip_prefix to avoid magic numbers transport-helper: avoid reading past end-of-string fast-import: fix read of uninitialized argv memory apply: use skip_prefix instead of raw addition refactor skip_prefix to return a boolean avoid using skip_prefix as a boolean daemon: mark some strings as const parse_diff_color_slot: drop ofs parameter

use skip_prefix to avoid repeated calculations

2014-06-20T17:45:19Z

In some cases, we use starts_with to check for a prefix, and then use an already-calculated prefix length to advance a pointer past the prefix. There are no magic numbers or duplicated strings here, but we can still make the code simpler and more obvious by using skip_prefix. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

http: fix charset detection of extract_content_type()

2014-06-17T22:25:00Z

extract_content_type() could not extract a charset parameter if the parameter is not the first one and there is a whitespace and a following semicolon just before the parameter. For example: text/plain; format=fixed ;charset=utf-8 And it also could not handle correctly some other cases, such as: text/plain; charset=utf-8; format=fixed text/plain; some-param="a long value with ;semicolons;"; charset=utf-8 Thanks-to: Jeff King Signed-off-by: Yi EungJun Signed-off-by: Junio C Hamano

http: default text charset to iso-8859-1

2014-05-27T16:59:22Z

This is specified by RFC 2616 as the default if no "charset" parameter is given. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano