git/notes-utils.h, branch jch

commit: fix leaking parents when calling `commit_tree_extended()`

2024-06-11T20:15:07Z

When creating commits via `commit_tree_extended()`, the caller passes in a string list of parents. This call implicitly transfers ownership of that list to the function, which is quite surprising to begin with. But to make matters worse, `commit_tree_extended()` doesn't even bother to free the list of parents in error cases. The result is a memory leak, and one that the caller cannot fix by themselves because they do not know whether parts of the string list have already been released. Refactor the code such that callers can keep ownership of the list of parents, which is getting indicated by parameter being a constant pointer now. Free the lists at the calling site and add a common exit path to those sites as required. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

notes-utils.c: remove the_repository references

2019-01-14T20:13:04Z

Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano

Add missing includes and forward declarations

2018-08-15T18:52:09Z

I looped over the toplevel header files, creating a temporary two-line C program for each consisting of #include "git-compat-util.h" #include $HEADER This patch is the result of manually fixing errors in compiling those tiny programs. Signed-off-by: Elijah Newren Signed-off-by: Junio C Hamano

commit: convert commit_tree* to object_id

2018-01-30T18:42:36Z

Convert the definitions and declarations of commit_tree and commit_tree_extended to use struct object_id and adjust all usages of these functions. Signed-off-by: Patryk Obara Signed-off-by: Junio C Hamano

builtin/notes: convert to struct object_id

2017-06-02T00:36:06Z

Convert most of the static functions to use struct object_id. In addition, convert copy_notes_for_rewrite and its callers. Signed-off-by: brian m. carlson Signed-off-by: Brandon Williams Signed-off-by: Junio C Hamano

notes: extract parse_notes_merge_strategy to notes-utils

2015-08-17T22:38:32Z

Signed-off-by: Jacob Keller Signed-off-by: Junio C Hamano

notes: extract enum notes_merge_strategy to notes-utils.h

2015-08-17T22:36:23Z

A future patch will extract parsing of the --strategy string into a helper function in notes.c and will require the enumeration definition. Signed-off-by: Jacob Keller Signed-off-by: Junio C Hamano

commit_tree: take a pointer/len pair rather than a const strbuf

2014-06-12T17:29:41Z

While strbufs are pretty common throughout our code, it is more flexible for functions to take a pointer/len pair than a strbuf. It's easy to turn a strbuf into such a pair (by dereferencing its members), but less easy to go the other way (you can strbuf_attach, but that has implications about memory ownership). This patch teaches commit_tree (and its associated callers and sub-functions) to take such a pair for the commit message rather than a strbuf. This makes passing the buffer around slightly more verbose, but means we can get rid of some dangerous strbuf_attach calls in the next patch. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

typofix: commit is spelled with two ems

2013-09-04T22:30:03Z

There are a handful of instances where we say commmit when we mean commit. Fix them. Signed-off-by: Junio C Hamano

Move create_notes_commit() from notes-merge.c into notes-utils.c

2013-06-12T17:38:13Z

create_notes_commit() is needed by both the notes-merge code, and by commit_notes() in notes-utils. Since it is generally useful, and not bound to the notes-merge machinery, we move it from (the more specific) notes-merge to (the more general) notes-utils. Signed-off-by: Johan Herland Signed-off-by: Junio C Hamano