git/notes.c, branch v2.17.2

sha1_file: convert write_sha1_file to object_id

2018-01-30T18:42:36Z

Convert the definition and declaration of write_sha1_file to struct object_id and adjust usage of this function. This commit also converts static function write_sha1_file_prepare, as it is closely related. Rename these functions to write_object_file and write_object_file_prepare respectively. Replace sha1_to_hex, hashcpy and hashclr with their oid equivalents wherever possible. Signed-off-by: Patryk Obara Signed-off-by: Junio C Hamano

notes: convert write_notes_tree to object_id

2018-01-30T18:42:36Z

Convert the definition and declaration of write_notes_tree to struct object_id and adjust usage of this function. Additionally, improve style of small part of this function, as old formatting made it hard to understand at glance what this part of code is doing. Signed-off-by: Patryk Obara Signed-off-by: Junio C Hamano

notes: convert combine_notes_* to object_id

2018-01-30T18:42:36Z

Convert the definition and declarations of combine_notes_* functions to struct object_id and adjust usage of these functions. Signed-off-by: Patryk Obara Signed-off-by: Junio C Hamano

Merge branch 'rs/hex-to-bytes-cleanup'

2017-11-09T05:31:27Z

Code cleanup. * rs/hex-to-bytes-cleanup: sha1_file: use hex_to_bytes() http-push: use hex_to_bytes() notes: move hex_to_bytes() to hex.c and export it

notes: move hex_to_bytes() to hex.c and export it

2017-11-01T01:35:35Z

Make the function for converting pairs of hexadecimal digits to binary available to other call sites. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

refs: convert read_ref and read_ref_full to object_id

2017-10-16T02:05:50Z

All but two of the call sites already have parameters using the hash parameter of struct object_id, so convert them to take a pointer to the struct directly. Also convert refs_read_refs_full, the underlying implementation. Signed-off-by: brian m. carlson Signed-off-by: Junio C Hamano

Merge branch 'mh/notes-cleanup'

2017-09-19T01:47:52Z

Code clean-up. * mh/notes-cleanup: load_subtree(): check that `prefix_len` is in the expected range load_subtree(): declare some variables to be `size_t` hex_to_bytes(): simpler replacement for `get_oid_hex_segment()` get_oid_hex_segment(): don't pad the rest of `oid` load_subtree(): combine some common code get_oid_hex_segment(): return 0 on success load_subtree(): only consider blobs to be potential notes load_subtree(): check earlier whether an internal node is a tree entry load_subtree(): separate logic for internal vs. terminal entries load_subtree(): fix incorrect comment load_subtree(): reduce the scope of some local variables load_subtree(): remove unnecessary conditional notes: make GET_NIBBLE macro more robust

load_subtree(): check that `prefix_len` is in the expected range

2017-09-08T18:16:13Z

This value, which is stashed in the last byte of an object_id hash, gets handed around a lot. So add a sanity check before using it in `load_subtree()`. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano

load_subtree(): declare some variables to be `size_t`

2017-08-26T16:21:01Z

* `prefix_len` * `path_len` * `i` It's good hygiene. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano

hex_to_bytes(): simpler replacement for `get_oid_hex_segment()`

2017-08-26T16:21:01Z

Now that `get_oid_hex_segment()` does less, it makes sense to rename it and simplify its semantics: * Instead of a `hex_len` parameter, which was the number of hex characters (and had to be even), use a `len` parameter, which is the number of resulting bytes. This removes then need for the check that `hex_len` is even and to divide it by two to determine the number of bytes. For good hygiene, declare the `len` parameter to be `size_t` instead of `unsigned int`. * Change the order of the arguments to the more traditional (dst, src, len). * Rename the function to `hex_to_bytes()`. * Remove a loop variable: just count `len` down instead. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano