git/object.c, branch v1.7.2

fix "bundle --stdin" segfault

2010-04-20T05:16:35Z

When passed an empty list, objects_array_remove_duplicates() corrupts it by changing the number of entries from 0 to 1. The problem lies in the condition of its main loop: for (ref = 0; ref < array->nr - 1; ref++) { The loop body manipulates the supplied object array. In the case of an empty array, it should not be doing anything at all. But array->nr is an unsigned quantity, so the code enters the loop, in particular increasing array->nr. Fix this by comparing (ref + 1 < array->nr) instead. This bug can be triggered by git bundle --stdin: $ echo HEAD | git bundle create some.bundle --stdin’ Segmentation fault (core dumped) The list of commits to bundle appears to be empty because of another bug: by the time the revision-walking machinery gets to look at it, standard input has already been consumed by rev-list, so this function gets an empty list of revisions. After this patch, git bundle --stdin still does not work; it just doesn’t segfault any more. Reported-by: Joey Hess Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano

object.c: remove unused functions

2010-01-18T06:49:36Z

object_list_append() and object_list_length}() are not used anywhere. Signed-off-by: Junio C Hamano

object: call "check_sha1_signature" with the replacement sha1

2009-06-01T00:02:59Z

Otherwise we get a "sha1 mismatch" error for replaced objects. Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano

Unify signedness in hashing calls

2009-05-20T07:02:24Z

Our hash_obj and hashtable_index calls and functions were doing a lot of funny things with signedness. Unify all of it to 'unsigned int'. Signed-off-by: Dan McGee Signed-off-by: Junio C Hamano

Fix type-punning issues

2009-05-17T05:41:18Z

In these two places we are casting part of our unsigned char sha1 array into an unsigned int, which violates GCCs strict-aliasing rules (and probably other compilers). Signed-off-by: Dan McGee Signed-off-by: Junio C Hamano

bundle: allow the same ref to be given more than once

2009-01-18T07:00:31Z

"git bundle create x master master" used to create a bundle that lists the same branch (master) twice. Cloning from such a bundle resulted in a needless warning "warning: Duplicated ref: refs/remotes/origin/master". Signed-off-by: Junio C Hamano

parse_object_buffer: don't ignore errors from the object specific parsing functions

2008-02-04T00:04:57Z

In the case of an malformed object, the object specific parsing functions would return an error, which is currently ignored. The object can be partial initialized in this case. This patch make parse_object_buffer propagate such errors. Signed-off-by: Martin Koegler Signed-off-by: Junio C Hamano

Don't dereference NULL upon lookup failure.

2007-12-22T19:15:38Z

Instead, signal the error just like the case we do upon encountering an object with an unknown type. Signed-off-by: Jim Meyering Signed-off-by: Junio C Hamano

Don't assume tree entries that are not dirs are blobs

2007-06-06T22:43:18Z

When scanning the trees in track_tree_refs() there is a "lazy" test that assumes that entries are either directories or files. Don't do that. Signed-off-by: Junio C Hamano

Merge branch 'maint-1.5.1' into maint

2007-05-25T02:01:50Z

* maint-1.5.1: fix memory leak in parse_object when check_sha1_signature fails name-rev: tolerate clock skew in committer dates