git/oidset.h, branch jch

oidset: introduce `oidset_equal()`

2025-11-25T20:15:59Z

Introduce a new function that allows the caller to verify whether two oidsets contain the exact same object IDs. Note that this change requires us to change `oidset_iter_init()` to accept a `const struct oidset`. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

oidset: pass hash algorithm when parsing file

2024-06-14T17:26:34Z

The `oidset_parse_file_carefully()` function implicitly depends on `the_repository` when parsing object IDs. Fix this by having callers pass in the hash algorithm to use. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

oidset: refactor oidset_insert_from_set()

2024-02-14T17:39:14Z

In a following commit, we will need to add all the oids from a set into another set. In "list-objects-filter.c", there is already a static function called add_all() to do that. Let's rename this function oidset_insert_from_set() and move it into oidset.{c,h} to make it generally available. While at it, let's remove a useless `!= NULL`. Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano

oidset: make oidset_size() an inline function

2021-09-12T23:14:32Z

oidset_size() just reads a single word from memory and returns it. Avoid the function call overhead for this trivial operation by turning it into an inline function. While we're at it, declare its parameter const to allow it to be used on read-only oidsets. Suggested-by: Jeff King Signed-off-by: René Scharfe Signed-off-by: Junio C Hamano

blame: validate and peel the object names on the ignore list

2020-09-25T05:20:58Z

The command reads list of object names to place on the ignore list either from the command line or from a file, but they are not checked with their object type (those read from the file are not even checked for object existence). Extend the oidset_parse_file() API and allow it to take a callback that can be used to die (e.g. when an inappropriate input is read) or modify the object name read (e.g. when a tag pointing at a commit is read, and the caller wants a commit object name), and use it in the code that handles ignore list. Signed-off-by: Junio C Hamano

Merge branch 'tb/commit-graph-split-strategy'

2020-05-01T20:39:52Z

"git commit-graph write" learned different ways to write out split files. * tb/commit-graph-split-strategy: Revert "commit-graph.c: introduce '--[no-]check-oids'" commit-graph.c: introduce '--[no-]check-oids' commit-graph.h: replace 'commit_hex' with 'commits' oidset: introduce 'oidset_size' builtin/commit-graph.c: introduce split strategy 'replace' builtin/commit-graph.c: introduce split strategy 'no-merge' builtin/commit-graph.c: support for '--split[=]' t/helper/test-read-graph.c: support commit-graph chains

Merge branch 'jk/oid-array-cleanups'

2020-04-22T20:42:49Z

Code cleanup. * jk/oid-array-cleanups: oidset: stop referring to sha1-array ref-filter: stop referring to "sha1 array" bisect: stop referring to sha1_array test-tool: rename sha1-array to oid-array oid_array: rename source file from sha1-array oid_array: use size_t for iteration oid_array: use size_t for count and allocation

oidset: introduce 'oidset_size'

2020-04-15T16:20:29Z

Occasionally, it may be useful for callers to know the number of object IDs in an oidset. Right now, the only way to compute this is to call 'kh_size' on the internal 'kh_set_oid_t'. Similar to how we wrap other 'kh_*' functions over the 'oidset' type, let's allow callers to compute this value by introducing 'oidset_size'. We will add its first caller in the subsequent commit. Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano

oidset: stop referring to sha1-array

2020-03-30T17:59:08Z

Ths has been oid_array for some time, though the source only recently moved from sha1-array.[ch] to oid-array.[ch]. In either case, we should say "oid-array" here. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

Merge branch 'en/oidset-uninclude-hashmap'

2020-03-25T20:57:44Z

Code clean-up. * en/oidset-uninclude-hashmap: oidset: remove unnecessary include