git/pack-bitmap-write.c, branch v2.48.2

global: mark code units that generate warnings with `-Wsign-compare`

2024-12-06T11:20:02Z

Mark code units that generate warnings with `-Wsign-compare`. This allows for a structured approach to get rid of all such warnings over time in a way that can be easily measured. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

pack-bitmap-write: fix leaking OID array

2024-09-30T18:23:07Z

Fix a leaking OID array in `write_pseudo_merges()`. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

pseudo-merge: fix various memory leaks

2024-09-30T18:23:06Z

Fix various memory leaks hit by the pseudo-merge machinery. These leaks are exposed by t5333, but plugging them does not yet make the whole test suite pass. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

Merge branch 'jk/drop-unused-parameters'

2024-08-26T18:32:22Z

Drop unused parameters from functions. * jk/drop-unused-parameters: diff-lib: drop unused index argument from get_stat_data() ref-filter: drop unused parameters from email_atom_option_parser() pack-bitmap: drop unused parameters from select_pseudo_merges() pack-bitmap: load writer config from repository parameter refs: drop some unused parameters from create_symref_lock()

pack-bitmap: drop unused parameters from select_pseudo_merges()

2024-08-17T16:44:41Z

We take the array of indexed_commits (and its length), but there's no need. The selection is based on ref reachability, not the linearized set of commits we're packing. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

pack-bitmap: load writer config from repository parameter

2024-08-17T16:44:40Z

In bitmap_writer_init(), we take a repository parameter but ever look at it. Most of the initialization here is independent of the repository, but we do load some config. So let's pass the repo we get down to load_pseudo_merges_from_config(), which in turn can use repo_config(), rather than depending on the_repository via git_config(). The outcome is the same, since all callers pass in the_repository anyway. But it takes us a step closer to getting rid of the global, and as a bonus it silences an unused parameter warning. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

pack-bitmap-write.c: select pseudo-merges even for small bitmaps

2024-08-15T18:25:02Z

Ordinarily, the pack-bitmap machinery will select some subset of reachable commits to receive bitmaps. But when there are fewer than 100 commits indexed in the first place, they will all receive bitmaps as a special case. When this happens, pseudo-merges are not generated, making it impossible to test pseudo-merge corner cases with fewer than 100 commits. Select pseudo-merges even for bitmaps with fewer than 100 commits to make such testing easier. In practice, this should not make a difference to non-testing bitmaps, as they are unlikely to be used when a repository has so few commits to begin with. Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano

pack-bitmap: drop redundant args from `bitmap_writer_finish()`

2024-08-15T18:23:15Z

In a similar fashion as the previous commit, drop a redundant argument from the `bitmap_writer_finish()` function. Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano

pack-bitmap: drop redundant args from `bitmap_writer_build()`

2024-08-15T18:22:27Z

In a similar fashion as the previous commit, drop a redundant argument from the `bitmap_writer_build()` function. Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano

pack-bitmap: drop redundant args from `bitmap_writer_build_type_index()`

2024-08-15T18:20:24Z

The previous commit ensures that the bitmap_writer's "to_pack" field is initialized early on, so the "to_pack" and "index_nr" arguments to `bitmap_writer_build_type_index()` are redundant. Drop them and adjust the callers accordingly. Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano