git/protocol-caps.c, branch v2.33.6Mirror of https://git.kernel.org/pub/scm/git/git.git/
https://git.shady.money/git/atom?h=v2.33.62021-08-31T18:15:16Zprotocol-caps.c: fix memory leak in send_info()2021-08-31T18:15:16ZÆvar Arnfjörð Bjarmasonavarab@gmail.com2021-08-31T13:46:42Zurn:sha1:88682b016dcbdbbdebdd2efd9b7de63e4395636f
Fix a memory leak in a2ba162cda (object-info: support for retrieving
object info, 2021-04-20) which appears to have been based on a
misunderstanding of how the pkt-line.c API works. There is no need to
strdup() input to packet_writer_write(), it's just a printf()-like
format function.
This fixes a potentially large memory leak, since the number of OID
lines the "object-info" call can be arbitrarily large (or a small one
if the request is small).
This makes t5701-git-serve.sh pass again under SANITIZE=leak, as it
did before a2ba162cda2.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Acked-by: Bruno Albuquerque <bga@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
object-info: support for retrieving object info2021-04-21T00:41:13ZBruno Albuquerquebga@google.com2021-04-20T23:38:31Zurn:sha1:a2ba162cda2acc171c3e36acbbc854792b093cb7
Sometimes it is useful to get information of an object without having to
download it completely.
Add the "object-info" capability that lets the client ask for
object-related information with their full hexadecimal object names.
Only sizes are returned for now.
Signed-off-by: Bruno Albuquerque <bga@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>