git/quote.h, branch v2.4.9

ls-tree: remove path filtering logic in show_tree

2014-12-01T19:32:34Z

ls-tree uses read_tree_recursive() which already does path filtering using pathspec. No need to filter one more time based on prefix only. "ls-tree ../somewhere" does not work because of this. write_name_quotedpfx() can now be retired because nobody else uses it. Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano

quote: remove sq_quote_print()

2013-07-30T15:13:38Z

Remove sq_quote_print() since it has no callers. Signed-off-by: Ramkumar Ramachandra Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano

for-each-ref, quote: convert _quote_print -> _quote_buf

2013-07-30T15:06:27Z

The print_value() function in for-each-ref.c prints values to stdout immediately using {sq|perl|python|tcl}_quote_print(). Change these lower-level quote functions to instead leave their results in strbuf so that we can later add post-processing to the results of them. Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Ramkumar Ramachandra Signed-off-by: Junio C Hamano

write_name{_quoted_relative,}(): remove redundant parameters

2013-06-26T18:22:06Z

After substitute path_relative() in quote.c with relative_path() from path.c, parameters (such as len and prefix_len) are redundant in function write_name() and write_name_quoted_relative(). The callers have already been audited that the strings they pass are properly NUL terminated and the length they give are the length of the string (or -1 that asks the length to be counted by the callee). Remove these now-redundant parameters. Signed-off-by: Jiang Xin Signed-off-by: Junio C Hamano

quote_path_relative(): remove redundant parameter

2013-06-26T18:16:48Z

quote_path_relative() used to take a counted string as its parameter (the string to be quoted). With an earlier change, it now uses relative_path() that does not take a counted string, and we have been passing only the pointer to the string since then. Remove the length parameter from quote_path_relative() to show that this parameter was redundant. All the changed lines show that the caller passed either -1 (to ask the function run strlen() on the string), or the length of the string, so the earlier conversion was safe. All the callers of quote_path_relative() that used to take counted string have been audited to make sure that they are passing length of the actual string (or -1 to ask the callee run strlen()) Signed-off-by: Jiang Xin Signed-off-by: Junio C Hamano

quote: provide sq_dequote_to_argv_array

2011-09-14T18:56:49Z

This is similar to sq_dequote_to_argv, but more convenient if you have an argv_array. It's tempting to just feed the components of the argv_array to sq_dequote_to_argv instead, but: 1. It wouldn't maintain the NULL-termination invariant of argv_array. 2. It doesn't match the memory ownership policy of argv_array (in which each component is free-able, not a pointer into a separate buffer). Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

quote.h: fix bogus comment

2011-09-14T18:44:05Z

Commit 758e915 made sq_quote_next static, removing it from quote.h. However, it forgot to update the related comment, making it appear as a confusing description of sq_quote_to_argv. Let's remove the crufty bits, and elaborate more on sq_quote_to_argv. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

quote.h: simplify the inclusion

2011-02-07T23:15:17Z

Attempting to include quote.h without first including strbuf.h results in warnings: ./quote.h:33:33: warning: ‘struct strbuf’ declared inside parameter list ./quote.h:33:33: warning: its scope is only this definition or declaration, which is probably not what you want ./quote.h:34:34: warning: ‘struct strbuf’ declared inside parameter list ... Add a toplevel declaration for struct strbuf to avoid this. While at it, stop including system headers from quote.h. git source files already need to include git-compat-util.h sooner to ensure the appropriate feature test macros are defined. Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano

quote.c: separate quoting and relative path generation

2010-06-05T16:14:13Z

This is in preparation of relative path support for ls-files, which quotes a path only if the line terminator is not the NUL character. Signed-off-by: Clemens Buchacher Signed-off-by: Junio C Hamano

quote.c: mark file-local function static

2010-01-12T09:06:08Z

Signed-off-by: Junio C Hamano