git/reftable/blocksource.c, branch v2.41.2

Merge branch 'cm/reftable-0-length-memset'

2022-05-04T16:51:29Z

Code clean-up. * cm/reftable-0-length-memset: reftable: avoid undefined behaviour breaking t0032

reftable: avoid undefined behaviour breaking t0032

2022-04-15T16:24:02Z

1214aa841bc (reftable: add blocksource, an abstraction for random access reads, 2021-10-07), makes the assumption that it is ok to free a reftable_block pointing to NULL if the size is also set to 0, but implements that using a memset call that at least in glibc based system will trigger a runtime exception if called with a NULL pointer as its first parameter. Avoid doing so by adding a conditional to check for the size in all three identically looking functions that were affected, and therefore, still allow memset to help catch callers that might incorrectly pass a NULL pointer with a non zero size, but avoiding the exception for the valid cases. Signed-off-by: Carlo Marcelo Arenas Belón Signed-off-by: Junio C Hamano

reftable: fix resource leak blocksource.c

2022-01-20T19:31:52Z

This would be triggered in the unlikely event of fstat() failing on an opened file. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: add blocksource, an abstraction for random access reads

2021-10-08T17:45:48Z

The reftable format is usually used with files for storage. However, we abstract away this using the blocksource data structure. This has two advantages: * log blocks are zlib compressed, and handling them is simplified if we can discard byte segments from within the block layer. * for unittests, it is useful to read and write in-memory. The blocksource allows us to abstract the data away from on-disk files. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano