git/reftable/reader.c, branch v2.41.2

reftable: drop unused parameter from reader_seek_linear()

2022-08-20T21:14:55Z

The reader code passes around a "struct reftable_reader" context variable. But the seek function doesn't need it; the table iterator we already get is sufficient. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

reftable: reject 0 object_id_len

2022-02-23T21:36:26Z

The spec says 2 <= object_id_len <= 31. We are lenient and allow 1, but we forbid 0, so we can be sure that we never read a 0-length key. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: make reftable_record a tagged union

2022-01-20T19:31:53Z

This reduces the amount of glue code, because we don't need a void pointer or vtable within the structure. The only snag is that reftable_index_record contain a strbuf, so it cannot be zero-initialized. To address this, use reftable_new_record() to return fresh instance, given a record type. Since reftable_new_record() doesn't cause heap allocation anymore, it should be balanced with reftable_record_release() rather than reftable_record_destroy(). Thanks to Peff for the suggestion. Helped-by: Jeff King Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: all xxx_free() functions accept NULL arguments

2022-01-20T19:31:52Z

This fixes NULL derefs in error paths. Spotted by Coverity. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: fix resource leak in block.c error path

2022-01-20T19:31:52Z

Add test coverage for corrupt zlib data. Fix memory leaks demonstrated by unittest. This problem was discovered by a Coverity scan. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: read reftable files

2021-10-08T17:45:48Z

This supports reading a single reftable file. The commit introduces an abstract iterator type, which captures the usecases both of reading individual refs, and iterating over a segment of the ref namespace. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano