git/reftable/reader.c, branch v2.48.2

reftable/system: stop depending on "hash.h"

2024-11-19T03:23:10Z

We include "hash.h" in "reftable/system.h" such that we can use hash format IDs as well as the raw size of SHA1 and SHA256. As we are in the process of converting the reftable library to become standalone we of course cannot rely on those constants anymore. Introduce a new `enum reftable_hash` to replace internal uses of the hash format IDs and new constants that replace internal uses of the hash size. Adapt the reftable backend to set up the correct hash function. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

reftable: explicitly handle hash format IDs

2024-11-19T03:23:09Z

The hash format IDs are used for two different things across the reftable codebase: - They are used as a 32 bit unsigned integer when reading and writing the header in order to identify the hash function. - They are used internally to identify which hash function is in use. When one only considers the second usecase one might think that one can easily change the representation of those hash IDs. But because those IDs end up in the reftable header and footer on disk it is important that those never change. Create separate constants `REFTABLE_FORMAT_ID_*` and use them in contexts where we read or write reftable headers. This serves multiple purposes: - It allows us to more easily discern cases where we actually use those constants for the on-disk format. - It detangles us from the same constants that are defined in libgit.a, which is another required step to convert the reftable library to become standalone. - It makes the next step easier where we stop using `GIT_*_FORMAT_ID` constants in favor of a custom enum. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

reftable: handle trivial `reftable_buf` errors

2024-10-17T20:59:56Z

Convert the reftable library such that we handle failures with the new `reftable_buf` interfaces. Signed-off-by: Patrick Steinhardt Signed-off-by: Taylor Blau

reftable/record: adapt `reftable_record_key()` to handle allocation failures

2024-10-17T20:59:56Z

The `reftable_record_key()` function cannot pass any errors to the caller as it has a `void` return type. Adapt it and its callers such that we can handle errors and start handling allocation failures. Signed-off-by: Patrick Steinhardt Signed-off-by: Taylor Blau

reftable: convert from `strbuf` to `reftable_buf`

2024-10-17T20:59:56Z

Convert the reftable library to use the `reftable_buf` interface instead of the `strbuf` interface. This is mostly a mechanical change via sed(1) with some manual fixes where functions for `strbuf` and `reftable_buf` differ. The converted code does not yet handle allocation failures. This will be handled in subsequent commits. Signed-off-by: Patrick Steinhardt Signed-off-by: Taylor Blau

reftable: introduce `REFTABLE_FREE_AND_NULL()`

2024-10-02T14:53:56Z

We have several calls to `FREE_AND_NULL()` in the reftable library, which of course uses free(3P). As the reftable allocators are pluggable we should rather call the reftable specific function, which is `reftable_free()`. Introduce a new macro `REFTABLE_FREE_AND_NULL()` and adapt the callsites accordingly. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

reftable: handle trivial allocation failures

2024-10-02T14:53:55Z

Handle trivial allocation failures in the reftable library and its unit tests. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

reftable/iter: handle allocation failures when creating indexed table iter

2024-10-02T14:53:54Z

Handle allocation failures in `new_indexed_table_ref_iter()`. While at it, rename the function to match our coding style. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

reftable/reader: handle allocation failures in `reader_init_iter()`

2024-10-02T14:53:53Z

Handle allocation failures in `reader_init_iter()`. This requires us to also adapt `reftable_reader_init_*_iterator()` to bubble up the new error codes. Adapt callers accordingly. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano

reftable/reader: handle allocation failures for unindexed reader

2024-10-02T14:53:53Z

Handle allocation failures when creating unindexed readers. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano