git/reftable/readwrite_test.c, branch v2.40.2

reftable: rename writer_stats to reftable_writer_stats

2022-02-23T21:36:26Z

This function is part of the reftable API, so it should use the reftable_ prefix Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: add test for length of disambiguating prefix

2022-02-23T21:36:26Z

The ID => ref map is trimming object IDs to a disambiguating prefix. Check that we are computing their length correctly. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: ensure that obj_id_len is >= 2 on writing

2022-02-23T21:36:26Z

When writing the same hash many times, we might decide to use a length-1 object ID prefix for the ObjectID => ref table, which is out of spec. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: add a test that verifies that writing empty keys fails

2022-02-23T21:36:26Z

Empty keys can only be written as ref records with empty names. The log record has a logical timestamp in the key, so the key is never empty. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

Merge branch 'hn/reftable-coverity-fixes'

2022-02-16T23:14:28Z

Problems identified by Coverity in the reftable code have been corrected. * hn/reftable-coverity-fixes: reftable: add print functions to the record types reftable: make reftable_record a tagged union reftable: remove outdated file reftable.c reftable: implement record equality generically reftable: make reftable-record.h function signatures const correct reftable: handle null refnames in reftable_ref_record_equal reftable: drop stray printf in readwrite_test reftable: order unittests by complexity reftable: all xxx_free() functions accept NULL arguments reftable: fix resource warning reftable: ignore remove() return value in stack_test.c reftable: check reftable_stack_auto_compact() return value reftable: fix resource leak blocksource.c reftable: fix resource leak in block.c error path reftable: fix OOB stack write in print functions

reftable: drop stray printf in readwrite_test

2022-01-20T19:31:53Z

Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: fix resource leak in block.c error path

2022-01-20T19:31:52Z

Add test coverage for corrupt zlib data. Fix memory leaks demonstrated by unittest. This problem was discovered by a Coverity scan. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: signal overflow

2021-12-23T20:28:34Z

reflog entries have unbounded size. In theory, each log ('g') block in reftable can have an arbitrary size, so the format allows for arbitrarily sized reflog messages. However, in the implementation, we are not scaling the log blocks up with the message, and writing a large message fails. This triggers a failure for reftable in t7006-pager.sh. Until this is fixed more structurally, report an error from within the reftable library for easier debugging. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: reftable file level tests

2021-10-08T17:45:48Z

With support for reading and writing files in place, we can construct files (in memory) and attempt to read them back. Because some sections of the format are optional (eg. indices, log entries), we have to exercise this code using multiple sizes of input data Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano