git/reftable, branch v2.37.2

Merge branch 'ep/maint-equals-null-cocci'

2022-05-20T22:26:59Z

Introduce and apply coccinelle rule to discourage an explicit comparison between a pointer and NULL, and applies the clean-up to the maintenance track. * ep/maint-equals-null-cocci: tree-wide: apply equals-null.cocci tree-wide: apply equals-null.cocci contrib/coccinnelle: add equals-null.cocci

Merge branch 'cm/reftable-0-length-memset'

2022-05-04T16:51:29Z

Code clean-up. * cm/reftable-0-length-memset: reftable: avoid undefined behaviour breaking t0032

tree-wide: apply equals-null.cocci

2022-05-02T17:09:21Z

Signed-off-by: Junio C Hamano

reftable: avoid undefined behaviour breaking t0032

2022-04-15T16:24:02Z

1214aa841bc (reftable: add blocksource, an abstraction for random access reads, 2021-10-07), makes the assumption that it is ok to free a reftable_block pointing to NULL if the size is also set to 0, but implements that using a memset call that at least in glibc based system will trigger a runtime exception if called with a NULL pointer as its first parameter. Avoid doing so by adding a conditional to check for the size in all three identically looking functions that were affected, and therefore, still allow memset to help catch callers that might incorrectly pass a NULL pointer with a non zero size, but avoiding the exception for the valid cases. Signed-off-by: Carlo Marcelo Arenas Belón Signed-off-by: Junio C Hamano

reftable: make assignments portable to AIX xlc v12.01

2022-03-28T20:58:10Z

Change the assignment syntax introduced in 66c0dabab5e (reftable: make reftable_record a tagged union, 2022-01-20) to be portable to AIX xlc v12.1: avar@gcc111:[/home/avar]xlc -qversion IBM XL C/C++ for AIX, V12.1 (5765-J02, 5725-C72) Version: 12.01.0000.0000 The error emitted before this was e.g.: "reftable/generic.c", line 133.26: 1506-196 (S) Initialization between types "char*" and "struct reftable_ref_record" is not allowed. The syntax in the pre-image is supported by e.g. xlc 13.01 on a newer AIX version: avar@gcc119:[/home/avar]xlc -qversion IBM XL C/C++ for AIX, V13.1.3 (5725-C72, 5765-J07) Version: 13.01.0003.0006 But as we've otherwise supported this compiler let's not break it entirely if it's easy to work around it. Suggested-by: René Scharfe Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano

reftable: rename writer_stats to reftable_writer_stats

2022-02-23T21:36:26Z

This function is part of the reftable API, so it should use the reftable_ prefix Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: add test for length of disambiguating prefix

2022-02-23T21:36:26Z

The ID => ref map is trimming object IDs to a disambiguating prefix. Check that we are computing their length correctly. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: ensure that obj_id_len is >= 2 on writing

2022-02-23T21:36:26Z

When writing the same hash many times, we might decide to use a length-1 object ID prefix for the ObjectID => ref table, which is out of spec. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: avoid writing empty keys at the block layer

2022-02-23T21:36:26Z

The public interface (reftable_writer) already ensures that keys are written in strictly increasing order, and an empty key by definition fails this check. However, by also enforcing this at the block layer, it is easier to verify that records (which are written into blocks) never have to consider the possibility of empty keys. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano

reftable: add a test that verifies that writing empty keys fails

2022-02-23T21:36:26Z

Empty keys can only be written as ref records with empty names. The log record has a logical timestamp in the key, so the key is never empty. Signed-off-by: Han-Wen Nienhuys Signed-off-by: Junio C Hamano