git/run-command.c, branch v2.3.3

Merge branch 'jc/hook-cleanup'

2014-12-22T20:27:10Z

Remove unused code. * jc/hook-cleanup: run-command.c: retire unused run_hook_with_custom_index()

run-command.c: retire unused run_hook_with_custom_index()

2014-12-01T16:39:43Z

This was originally meant to be used to rewrite run_commit_hook() that only special cases the GIT_INDEX_FILE environment, but the run_hook_ve() refactoring done earlier made the implementation of run_commit_hook() thin and clean enough. Nobody uses this, so retire it as an unfinished clean-up made unnecessary. Signed-off-by: Junio C Hamano

run-command: use void to declare that functions take no parameters

2014-11-10T22:43:19Z

Explicitly declare that git_atexit_dispatch() and git_atexit_clear() take no parameters instead of leaving their parameter list empty and thus unspecified. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

Merge branch 'eb/no-pthreads'

2014-10-24T21:59:10Z

Allow us build with NO_PTHREADS=NoThanks compilation option. * eb/no-pthreads: Handle atexit list internaly for unthreaded builds pack-objects: set number of threads before checking and warning index-pack: fix compilation with NO_PTHREADS

Handle atexit list internaly for unthreaded builds

2014-10-19T22:38:30Z

Wrap atexit()s calls on unthreaded builds to handle callback list internally. This is needed because on unthreaded builds, asyncs inherits parent's atexit() list, that gets run as soon as the async exit()s (and again at the end of async's parent process). That led to remove temporary files too early. Also remove a by-atexit-callback guard against this kind of issue in clone.c, as this patch makes it redundant. Fixes test 5537 (temporary shallow file vanished before unpack-objects could open it) BTW remove an unused variable in shallow.c. Helped-by: Duy Nguyen Helped-by: Andreas Schwab Helped-by: Junio C Hamano Signed-off-by: Etienne Buira Signed-off-by: Junio C Hamano

run-command: add env_array, an optional argv_array for env

2014-10-19T22:26:31Z

Similar to args, add a struct argv_array member to struct child_process that simplifies specifying the environment for children. It is freed automatically by finish_command() or if start_command() encounters an error. Suggested-by: Jeff King Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

run-command: inline prepare_run_command_v_opt()

2014-08-20T16:56:12Z

Merge prepare_run_command_v_opt() and its only caller. This removes a pointer indirection and allows to initialize the struct child_process using CHILD_PROCESS_INIT. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

run-command: call run_command_v_opt_cd_env() instead of duplicating it

2014-08-20T16:55:41Z

Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

run-command: introduce child_process_init()

2014-08-20T16:54:58Z

Add a helper function for initializing those struct child_process variables for which the macro CHILD_PROCESS_INIT can't be used. Suggested-by: Jeff King Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

run-command: introduce CHILD_PROCESS_INIT

2014-08-20T16:53:37Z

Most struct child_process variables are cleared using memset first after declaration. Provide a macro, CHILD_PROCESS_INIT, that can be used to initialize them statically instead. That's shorter, doesn't require a function call and is slightly more readable (especially given that we already have STRBUF_INIT, ARGV_ARRAY_INIT etc.). Helped-by: Johannes Sixt Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano