git/strbuf.c, branch v1.6.3

strbuf_check_branch_ref(): a helper to check a refname for a branch

2009-03-23T06:52:11Z

This allows a common calling sequence strbuf_branchname(&ref, name); strbuf_splice(&ref, 0, 0, "refs/heads/", 11); if (check_ref_format(ref.buf)) die(...); to be refactored into if (strbuf_check_branch_ref(&ref, name)) die(...); Signed-off-by: Junio C Hamano

strbuf_branchname(): a wrapper for branch name shorthands

2009-03-23T06:44:08Z

The function takes a user-supplied string that is supposed to be a branch name, and puts it in a strbuf after expanding possible shorthand notation. A handful of open coded sequence to do this in the existing code have been changed to use this helper function. Signed-off-by: Junio C Hamano

Microoptimize strbuf_cmp

2009-03-20T16:35:32Z

It can be less object code and may be even faster, even if at the moment there is no callers to take an advantage of that. This implementation can be trivially made inlinable later. Signed-off-by: Alex Riesen Signed-off-by: Junio C Hamano

strbuf: instate cleanup rule in case of non-memory errors

2009-01-07T06:13:43Z

Make all strbuf functions that can fail free() their memory on error if they have allocated it. They don't shrink buffers that have been grown, though. This allows for easier error handling, as callers only need to call strbuf_release() if A) the command succeeded or B) if they would have had to do so anyway because they added something to the strbuf themselves. Bonus hunk: document strbuf_readlink. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

Add generic 'strbuf_readlink()' helper function

2008-12-17T21:36:30Z

It was already what 'git apply' did in read_old_data(), just export it as a real function, and make it be more generic. In particular, this handles the case of the lstat() st_size data not matching the readlink() return value properly (which apparently happens at least on NTFS under Linux). But as a result of this you could also use the new function without even knowing how big the link is going to be, and it will allocate an appropriately sized buffer. So we pass in the st_size of the link as just a hint, rather than a fixed requirement. Signed-off-by: Linus Torvalds Signed-off-by: Junio C Hamano

add strbuf_expand_dict_cb(), a helper for simple cases

2008-11-24T03:55:47Z

The new callback function strbuf_expand_dict_cb() can be used together with strbuf_expand() if there is only a small number of placeholders for static replacement texts. It expects its dictionary as an array of placeholder+value pairs as context parameter, terminated by an entry with the placeholder member set to NULL. The new helper is intended to aid converting the remaining calls of interpolate(). strbuf_expand() is smaller, more flexible and can be used to go faster than interpolate(), so it should replace the latter. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

Add some useful functions for strbuf manipulation.

2008-07-13T21:04:04Z

Signed-off-by: Lukas Sandström Signed-off-by: Junio C Hamano

Make some strbuf_*() struct strbuf arguments const.

2008-07-13T20:59:34Z

Signed-off-by: Lukas Sandström Signed-off-by: Junio C Hamano

Avoid a useless prefix lookup in strbuf_expand()

2008-02-10T07:57:08Z

Currently, the --pretty=format prefix is looked up in a tight loop in strbuf_expand(), if prefix is found it is then used as argument for format_commit_item() that does another search by a switch statement to select the proper operation. Because the switch statement is already able to discard unknown matches we don't need the prefix lookup before to call format_commit_item(). Signed-off-by: Marco Costalba Signed-off-by: Junio C Hamano

Uninline prefixcmp()

2008-01-03T09:23:12Z

Now the routine is an open-coded loop that avoids an extra strlen() in the previous implementation, it got a bit too big to be inlined. Uninlining it makes code footprint smaller but the result still retains the avoidance of strlen() cost. Signed-off-by: Junio C Hamano