git/strbuf.h, branch v2.1.2

Merge branch 'jk/strip-suffix'

2014-07-16T18:26:00Z

* jk/strip-suffix: prepare_packed_git_one: refactor duplicate-pack check verify-pack: use strbuf_strip_suffix strbuf: implement strbuf_strip_suffix index-pack: use strip_suffix to avoid magic numbers use strip_suffix instead of ends_with in simple cases replace has_extension with ends_with implement ends_with via strip_suffix add strip_suffix function sha1_file: replace PATH_MAX buffer with strbuf in prepare_packed_git_one()

strbuf: implement strbuf_strip_suffix

2014-06-30T20:43:32Z

You can almost get away with just calling "strip_suffix_mem" on a strbuf's buf and len fields. But we also need to move the NUL-terminator to satisfy strbuf's invariants. Let's provide a convenience wrapper that handles this. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

strbuf: add xstrfmt helper

2014-06-19T19:25:17Z

You can use a strbuf to build up a string from parts, and then detach it. In the general case, you might use multiple strbuf_add* functions to do the building. However, in many cases, a single strbuf_addf is sufficient, and we end up with: struct strbuf buf = STRBUF_INIT; ... strbuf_addf(&buf, fmt, some, args); str = strbuf_detach(&buf, NULL); We can make this much more readable (and avoid introducing an extra variable, which can clutter the code) by introducing a convenience function: str = xstrfmt(fmt, some, args); Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

Merge branch 'jk/http-errors'

2014-06-16T19:18:36Z

Propagate the error messages from the webserver better to the client coming over the HTTP transport. * jk/http-errors: http: default text charset to iso-8859-1 remote-curl: reencode http error messages strbuf: add strbuf_reencode helper http: optionally extract charset parameter from content-type http: extract type/subtype portion of content-type t5550: test display of remote http error messages t/lib-httpd: use write_script to copy CGI scripts test-lib: preserve GIT_CURL_VERBOSE from the environment

Merge branch 'jk/strbuf-tolower'

2014-06-16T17:07:17Z

* jk/strbuf-tolower: strbuf: add strbuf_tolower function

Merge branch 'jk/daemon-tolower'

2014-06-16T17:07:15Z

* jk/daemon-tolower: daemon/config: factor out duplicate xstrdup_tolower

strbuf: add strbuf_reencode helper

2014-05-27T16:59:21Z

This is a convenience wrapper around `reencode_string_len` and `strbuf_attach`. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

strbuf: add strbuf_tolower function

2014-05-23T21:09:58Z

This is a convenience wrapper to call tolower on each character of the string. This makes config's lowercase() function obsolete, though note that because we have a strbuf, we are careful to operate over the whole strbuf, rather than assuming that a NUL is the end-of-string. We could continue to offer a pure-string lowercase, but there would be no callers (in most pure-string cases, we actually duplicate and lowercase the duplicate, for which we have the xstrdup_tolower wrapper). Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

daemon/config: factor out duplicate xstrdup_tolower

2014-05-23T19:39:44Z

We have two implementations of the same function; let's drop that to one. We take the name from daemon.c, but the implementation (which is just slightly more efficient) from the config code. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

strbuf: style fix -- top opening bracket on a separate line

2014-03-03T20:26:08Z

Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano