git/submodule-config.c, branch v2.9.3

Merge branch 'rs/submodule-config-code-cleanup' into maint

2016-08-08T21:21:46Z

Code cleanup. * rs/submodule-config-code-cleanup: submodule-config: fix test binary crashing when no arguments given submodule-config: combine early return code into one goto submodule-config: passing name reference for .gitmodule blobs submodule-config: use explicit empty string instead of strbuf in config_from()

submodule-config: combine early return code into one goto

2016-07-28T20:05:31Z

So we have simpler return handling code and all the cleanup code in almost one place. Signed-off-by: Heiko Voigt Reviewed-by: Stefan Beller Signed-off-by: Junio C Hamano

submodule-config: passing name reference for .gitmodule blobs

2016-07-28T20:05:14Z

Commit 959b5455 (submodule: implement a config API for lookup of .gitmodules values, 2015-08-18) implemented the initial version of the submodule config cache. During development of that initial version we extracted the function gitmodule_sha1_from_commit(). During that process we missed that the strbuf rev was still used in config_from() and now is left empty. Lets fix this by also returning this string. This means that now when reading .gitmodules from revisions, the error messages also contain a reference to the blob they are from. Signed-off-by: Heiko Voigt Reviewed-by: Stefan Beller Signed-off-by: Junio C Hamano

submodule-config: use explicit empty string instead of strbuf in config_from()

2016-07-19T19:16:57Z

Use a string constant instead of an empty strbuf to shorten the code and make it easier to read. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

Merge branch 'sb/misc-cleanups' into HEAD

2016-05-18T21:40:15Z

* sb/misc-cleanups: submodule-config: don't shadow `cache` config.c: drop local variable credential-cache, send_request: close fd when done bundle: don't leak an fd in case of early return abbrev_sha1_in_line: don't leak memory notes: don't leak memory in git_config_get_notes_strategy

Merge branch 'sb/misc-cleanups'

2016-05-10T20:40:29Z

* sb/misc-cleanups: submodule-config: don't shadow `cache` config.c: drop local variable

Merge branch 'ak/use-hashmap-iter-first-in-submodule-config' into maint

2016-04-29T21:15:58Z

Minor code cleanup. * ak/use-hashmap-iter-first-in-submodule-config: submodule-config: use hashmap_iter_first()

submodule-config: don't shadow `cache`

2016-04-28T16:56:16Z

Lots of internal functions in submodule-confic.c have a first parameter `struct submodule_cache *cache`, which currently always refers to the global variable `cache` in the file. To avoid confusion rename the global `cache` variable. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano

Merge branch 'ak/use-hashmap-iter-first-in-submodule-config'

2016-04-13T21:12:29Z

Minor code cleanup. * ak/use-hashmap-iter-first-in-submodule-config: submodule-config: use hashmap_iter_first()

Merge branch 'sb/submodule-parallel-update'

2016-04-06T18:39:01Z

A major part of "git submodule update" has been ported to C to take advantage of the recently added framework to run download tasks in parallel. * sb/submodule-parallel-update: clone: allow an explicit argument for parallel submodule clones submodule update: expose parallelism to the user submodule helper: remove double 'fatal: ' prefix git submodule update: have a dedicated helper for cloning run_processes_parallel: rename parameters for the callbacks run_processes_parallel: treat output of children as byte array submodule update: direct error message to stderr fetching submodules: respect `submodule.fetchJobs` config option submodule-config: drop check against NULL submodule-config: keep update strategy around