git/t/t4012-diff-binary.sh, branch v2.4.9

t4012-diff-binary.sh: use the $( ... ) construct for command substitution

2014-04-30T18:08:05Z

The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`$.*$`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto Reviewed-by: Matthieu Moy Signed-off-by: Junio C Hamano

Fix tests under GETTEXT_POISON on git-apply

2012-08-27T16:26:30Z

Use the i18n-specific test functions in test scripts for git-apply. This issue was was introduced in the following commits: de373 i18n: apply: mark parseopt strings for translation 3638e i18n: apply: mark strings for translation and been broken under GETTEXT_POISON=YesPlease since. Signed-off-by: Jiang Xin Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano

t4012: Use test_must_fail instead of if-else

2012-07-16T20:51:25Z

Make the code less bulky and easier to read. Also do not overlook failures like e.g. git failing because of unexpected signals. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano

t4012: use 'printf' instead of 'dd' to generate a binary file

2012-07-16T20:51:10Z

For some reason, 'echo X | dd bs=1k seek=1' creates a file with 2050 bytes on Windows instead of the expected 1026 bytes, so that a test fails. Since the actual contents of the file are irrelevant as long as there is at least one zero byte so that the diff machinery recognizes it as binary, use printf to generate it. Signed-off-by: Johannes Sixt Signed-off-by: Junio C Hamano Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano

t4012: Re-indent test snippets

2012-07-16T20:50:50Z

Most one-level indents were 1 HT (horizontal tab) followed by 1 SP. Remove the SP. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano

t4012: Make --shortstat test more robust

2012-07-16T20:50:28Z

The --shortstat test depends on the same scenario as the --stat test. Use the part of the same expected result for the --stat test to avoid duplicating it manually. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano

t4012: Break up pipe into serial redirections

2012-07-16T20:49:58Z

Do not hide possible git errors by masking its process exit status. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano

t4012: Actually quote the sed script

2012-07-16T20:49:29Z

The nested quoting is not needed in this cases, thus the previous version did work just fine. Nevertheless the usage is misleading, so just achieve nested quoting by using double quotes instead. Lower the probability of breakage in the future and make the code easier to read. NOTE: Just dropping the single quotes around the sed arguments would have also been possible. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano

t4012: Unquote git command fragment in test title

2012-07-11T22:36:33Z

The command fragments are quoted nowhere else in title texts of this file, thus make this one consistent with all other titles. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano

t4012: modernize style for quoting

2012-07-11T22:36:14Z

This quoting style is used by all newly added test code. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano