git/t/t4014-format-patch.sh, branch v2.24.2

Merge branch 'bw/format-patch-o-create-leading-dirs'

2019-10-24T04:34:02Z

Test update. * bw/format-patch-o-create-leading-dirs: t4014: make output-directory tests self-contained

t4014: make output-directory tests self-contained

2019-10-23T02:08:58Z

As noted by Gábor in [1], the new tests in edefc31873 ("format-patch: create leading components of output directory", 2019-10-11) cannot be run independently. Fix this. [1] https://public-inbox.org/git/20191011144650.GM29845@szeder.dev/ Signed-off-by: Bert Wesarg Signed-off-by: Junio C Hamano

Merge branch 'bw/format-patch-o-create-leading-dirs'

2019-10-18T02:40:48Z

"git format-patch -o " did an equivalent of "mkdir " not "mkdir -p ", which is being corrected. * bw/format-patch-o-create-leading-dirs: format-patch: create leading components of output directory

format-patch: create leading components of output directory

2019-10-12T02:51:20Z

'git format-patch -o ' did an equivalent of 'mkdir ' not 'mkdir -p ', which is being corrected. Avoid the usage of 'adjust_shared_perm' on the leading directories which may have security implications. Achieved by temporarily disabling of 'config.sharedRepository' like 'git init' does. Signed-off-by: Bert Wesarg Signed-off-by: Junio C Hamano

t4014: treat rev-list output as the expected value

2019-10-09T01:44:40Z

In 6bd26f58ea (t4014: use test_line_count() where possible, 2019-08-27), we converted many test cases to take advantage of the test_line_count() function. In one conversion, we inverted the expected and actual value as tested by test_line_count(). Although functionally correct, if format-patch ever produced incorrect output, the debugging output would be a bunch of hashes which would be difficult to debug. Invert the expected and actual values provided to test_line_count() so that if format-patch produces incorrect output, the debugging output will be a list of human-readable files instead. Helped-by: SZEDER GÃ¡bor Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano

t4014: stop losing return codes of git commands

2019-09-05T19:58:52Z

Currently, there are two ways where the return codes of Git commands are lost. The first way is when a command is in the upstream of a pipe. In a pipe, only the return code of the last command is used. Thus, all other commands will have their return codes masked. Rewrite pipes so that there are no Git commands upstream. The other way is when a command is in a non-assignment subshell. The return code will be lost in favour of the surrounding command's. Rewrite instances of this such that Git commands output to a file and surrounding commands only call subshells with non-Git commands. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano

t4014: remove confusing pipe in check_threading()

2019-09-05T19:58:52Z

In check_threading(), there was a Git command in the upstream of a pipe. In order to not lose its status code, it was saved into a file. However, this may be confusing so rewrite to redirect IO to file. This allows us to directly use the conventional &&-chain. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano

t4014: use test_line_count() where possible

2019-09-05T19:58:52Z

Convert all instances of `cnt=$(... | wc -l) && test $cnt = N` into uses of `test_line_count()`. While we're at it, convert one instance of a Git command upstream of a pipe into two commands. This prevents a failure of a Git command from being masked since only the return code of the last member of the pipe is shown. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano

t4014: let sed open its own files

2019-09-05T19:58:52Z

In some cases, we were using a redirection operator to feed input into sed. However, since sed is capable of opening its own files, make sed open its own files instead of redirecting input into it. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano

t4014: drop redirections to /dev/null

2019-09-05T19:58:52Z

Since output is silenced when running without `-v` and debugging output is useful with `-v`, remove redirections to /dev/null as it is not useful. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano