<feed xmlns='http://www.w3.org/2005/Atom'>
<title>git/t, branch v2.44.0</title>
<subtitle>Mirror of https://git.kernel.org/pub/scm/git/git.git/
</subtitle>
<id>https://git.shady.money/git/atom?h=v2.44.0</id>
<link rel='self' href='https://git.shady.money/git/atom?h=v2.44.0'/>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/'/>
<updated>2024-02-20T04:58:06Z</updated>
<entry>
<title>Merge branch 'la/trailer-cleanups'</title>
<updated>2024-02-20T04:58:06Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-20T04:58:06Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=58aa645fc0e3690b250ba5ab0ecabad2401216a6'/>
<id>urn:sha1:58aa645fc0e3690b250ba5ab0ecabad2401216a6</id>
<content type='text'>
Fix to an already-graduated topic.

* la/trailer-cleanups:
  trailer: fix comment/cut-line regression with opts-&gt;no_divider
</content>
</entry>
<entry>
<title>trailer: fix comment/cut-line regression with opts-&gt;no_divider</title>
<updated>2024-02-20T03:06:18Z</updated>
<author>
<name>Jeff King</name>
<email>peff@peff.net</email>
</author>
<published>2024-02-20T01:09:36Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=bc47139f4ff6c0c41d4c854ca74c35b1006a464a'/>
<id>urn:sha1:bc47139f4ff6c0c41d4c854ca74c35b1006a464a</id>
<content type='text'>
Commit 97e9d0b78a (trailer: find the end of the log message, 2023-10-20)
combined two code paths for finding the end of the log message. For the
"no_divider" case, we used to use find_trailer_end(), and that has now
been rolled into find_end_of_log_message(). But there's a regression;
that function returns early when no_divider is set, returning the whole
string.

That's not how find_trailer_end() behaved. Although it did skip the
"---" processing (which is what "no_divider" is meant to do), we should
still respect ignored_log_message_bytes(), which covers things like
comments, "commit -v" cut lines, and so on.

The bug is actually in the interpret-trailers command, but the obvious
way to experience it is by running "commit -v" with a "--trailer"
option. The new trailer will be added at the end of the verbose diff,
rather than before it (and consequently will be ignored entirely, since
everything after the diff's intro scissors line is thrown away).

I've added two tests here: one for interpret-trailers directly, which
shows the bug via the parsing routines, and one for "commit -v".

The fix itself is pretty simple: instead of returning early, no_divider
just skips the "---" handling but still calls ignored_log_message_bytes().

Reported-by: Philippe Blain &lt;levraiphilippeblain@gmail.com&gt;
Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>Merge branch 'pb/complete-config'</title>
<updated>2024-02-14T23:36:06Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-14T23:36:06Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=89400c361510c58bbbeac7d98967627636069340'/>
<id>urn:sha1:89400c361510c58bbbeac7d98967627636069340</id>
<content type='text'>
The command line completion script (in contrib/) learned to
complete configuration variable names better.

* pb/complete-config:
  completion: add and use __git_compute_second_level_config_vars_for_section
  completion: add and use __git_compute_first_level_config_vars_for_section
  completion: complete 'submodule.*' config variables
  completion: add space after config variable names also in Bash 3
</content>
</entry>
<entry>
<title>Merge branch 'vn/rebase-with-cherry-pick-authorship'</title>
<updated>2024-02-14T23:36:05Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-14T23:36:05Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=c036a145c380e79db5fab5aafb87c4981e11cc9e'/>
<id>urn:sha1:c036a145c380e79db5fab5aafb87c4981e11cc9e</id>
<content type='text'>
"git cherry-pick" invoked during "git rebase -i" session lost
the authorship information, which has been corrected.

* vn/rebase-with-cherry-pick-authorship:
  sequencer: unset GIT_CHERRY_PICK_HELP for 'exec' commands
</content>
</entry>
<entry>
<title>Merge branch 'pw/gc-during-rebase'</title>
<updated>2024-02-14T23:36:05Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-14T23:36:05Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=09e0aa64b3fbdc6df541cd2beefe70170f038252'/>
<id>urn:sha1:09e0aa64b3fbdc6df541cd2beefe70170f038252</id>
<content type='text'>
The sequencer machinery does not use the ref API and instead
records names of certain objects it needs for its correct operation
in temporary files, which makes these objects susceptible to loss
by garbage collection.  These temporary files have been added as
starting points for reachability analysis to fix this.

* pw/gc-during-rebase:
  prune: mark rebase autostash and orig-head as reachable
</content>
</entry>
<entry>
<title>Merge branch 'jc/unit-tests-make-relative-fix'</title>
<updated>2024-02-13T22:31:11Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-13T22:31:11Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=9115864cb59473aee9fcb9b0826342444559414d'/>
<id>urn:sha1:9115864cb59473aee9fcb9b0826342444559414d</id>
<content type='text'>
The mechanism to report the filename in the source code, used by
the unit-test machinery, assumed that the compiler expanded __FILE__
to the path to the source given to the $(CC), but some compilers
give full path, breaking the output.  This has been corrected.

* jc/unit-tests-make-relative-fix:
  unit-tests: do show relative file paths on non-Windows, too
</content>
</entry>
<entry>
<title>Merge branch 'tb/multi-pack-reuse-experiment'</title>
<updated>2024-02-12T21:16:11Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-12T21:16:11Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=3b89ff16aabd01ea2fecf507e72cf0c91f572751'/>
<id>urn:sha1:3b89ff16aabd01ea2fecf507e72cf0c91f572751</id>
<content type='text'>
Setting `feature.experimental` opts the user into multi-pack reuse
experiment

* tb/multi-pack-reuse-experiment:
  pack-objects: enable multi-pack reuse via `feature.experimental`
  t5332-multi-pack-reuse.sh: extract pack-objects helper functions
</content>
</entry>
<entry>
<title>Merge branch 'vd/for-each-ref-sort-with-formatted-timestamp'</title>
<updated>2024-02-12T21:16:11Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-12T21:16:11Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=d4833b22abc0093153534cfaa93bb90be9a708ca'/>
<id>urn:sha1:d4833b22abc0093153534cfaa93bb90be9a708ca</id>
<content type='text'>
"git branch" and friends learned to use the formatted text as
sorting key, not the underlying timestamp value, when the --sort
option is used with author or committer timestamp with a format
specifier (e.g., "--sort=creatordate:format:%H:%M:%S").

* vd/for-each-ref-sort-with-formatted-timestamp:
  ref-filter.c: sort formatted dates by byte value
</content>
</entry>
<entry>
<title>Merge branch 'pw/show-ref-pseudorefs'</title>
<updated>2024-02-12T21:16:11Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-12T21:16:11Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=b3370dd51edb7f087754f0090ab483e9d1a2161e'/>
<id>urn:sha1:b3370dd51edb7f087754f0090ab483e9d1a2161e</id>
<content type='text'>
"git show-ref --verify" did not show things like "CHERRY_PICK_HEAD",
which has been corrected.

* pw/show-ref-pseudorefs:
  t1400: use show-ref to check pseudorefs
  show-ref --verify: accept pseudorefs
</content>
</entry>
<entry>
<title>Merge branch 'ps/report-failure-from-git-stash'</title>
<updated>2024-02-12T21:16:11Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-12T21:16:11Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=70550a224263099c76276eaa57ac9d0b0c724a99'/>
<id>urn:sha1:70550a224263099c76276eaa57ac9d0b0c724a99</id>
<content type='text'>
"git stash" sometimes was silent even when it failed due to
unwritable index file, which has been corrected.

* ps/report-failure-from-git-stash:
  builtin/stash: report failure to write to index
</content>
</entry>
</feed>
