aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2020-09-25 15:25:40 -0700
committerJunio C Hamano <gitster@pobox.com>2020-09-25 15:25:40 -0700
commit9f4588d72b035714d4524342479e375742ac05b3 (patch)
tree5dc6b95bf502b2b8d664567dbd2d006ef1acf765
parentMerge branch 'jx/proc-receive-hook' (diff)
parentgit-p4: use HEAD~$n to find parent commit for unshelve (diff)
downloadgit-9f4588d72b035714d4524342479e375742ac05b3.tar.gz
git-9f4588d72b035714d4524342479e375742ac05b3.zip
Merge branch 'ld/p4-unshelve-fix'
The "unshelve" subcommand of "git p4" used incorrectly used commit^N where it meant to say commit~N to name the Nth generation ancestor, which has been corrected. * ld/p4-unshelve-fix: git-p4: use HEAD~$n to find parent commit for unshelve git-p4 unshelve: adding a commit breaks git-p4 unshelve
-rwxr-xr-xgit-p4.py2
-rwxr-xr-xt/t9832-unshelve.sh5
2 files changed, 5 insertions, 2 deletions
diff --git a/git-p4.py b/git-p4.py
index ca79dc0900..4433ca53de 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -4237,7 +4237,7 @@ class P4Unshelve(Command):
"""
for parent in (range(65535)):
- log = extractLogMessageFromGitCommit("{0}^{1}".format(starting_point, parent))
+ log = extractLogMessageFromGitCommit("{0}~{1}".format(starting_point, parent))
settings = extractSettingsGitLog(log)
if 'change' in settings:
return settings
diff --git a/t/t9832-unshelve.sh b/t/t9832-unshelve.sh
index e9276c48f4..7194fb2855 100755
--- a/t/t9832-unshelve.sh
+++ b/t/t9832-unshelve.sh
@@ -29,8 +29,11 @@ test_expect_success 'init depot' '
)
'
+# Create an initial clone, with a commit unrelated to the P4 change
+# on HEAD
test_expect_success 'initial clone' '
- git p4 clone --dest="$git" //depot/@all
+ git p4 clone --dest="$git" //depot/@all &&
+ test_commit -C "$git" "unrelated"
'
test_expect_success 'create shelved changelist' '