diff options
| author | Junio C Hamano <gitster@pobox.com> | 2020-09-25 15:25:40 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-09-25 15:25:40 -0700 |
| commit | 9f4588d72b035714d4524342479e375742ac05b3 (patch) | |
| tree | 5dc6b95bf502b2b8d664567dbd2d006ef1acf765 | |
| parent | Merge branch 'jx/proc-receive-hook' (diff) | |
| parent | git-p4: use HEAD~$n to find parent commit for unshelve (diff) | |
| download | git-9f4588d72b035714d4524342479e375742ac05b3.tar.gz git-9f4588d72b035714d4524342479e375742ac05b3.zip | |
Merge branch 'ld/p4-unshelve-fix'
The "unshelve" subcommand of "git p4" used incorrectly used
commit^N where it meant to say commit~N to name the Nth generation
ancestor, which has been corrected.
* ld/p4-unshelve-fix:
git-p4: use HEAD~$n to find parent commit for unshelve
git-p4 unshelve: adding a commit breaks git-p4 unshelve
| -rwxr-xr-x | git-p4.py | 2 | ||||
| -rwxr-xr-x | t/t9832-unshelve.sh | 5 |
2 files changed, 5 insertions, 2 deletions
@@ -4237,7 +4237,7 @@ class P4Unshelve(Command): """ for parent in (range(65535)): - log = extractLogMessageFromGitCommit("{0}^{1}".format(starting_point, parent)) + log = extractLogMessageFromGitCommit("{0}~{1}".format(starting_point, parent)) settings = extractSettingsGitLog(log) if 'change' in settings: return settings diff --git a/t/t9832-unshelve.sh b/t/t9832-unshelve.sh index e9276c48f4..7194fb2855 100755 --- a/t/t9832-unshelve.sh +++ b/t/t9832-unshelve.sh @@ -29,8 +29,11 @@ test_expect_success 'init depot' ' ) ' +# Create an initial clone, with a commit unrelated to the P4 change +# on HEAD test_expect_success 'initial clone' ' - git p4 clone --dest="$git" //depot/@all + git p4 clone --dest="$git" //depot/@all && + test_commit -C "$git" "unrelated" ' test_expect_success 'create shelved changelist' ' |
