aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2019-10-07 11:33:01 +0900
committerJunio C Hamano <gitster@pobox.com>2019-10-07 11:33:01 +0900
commitcabb145fe36c4e11ed9fd18b852b218e9407ac8b (patch)
tree1fee03025eaeb895eeb4e5717ee2d9981de0d461
parentMerge branch 'sg/t-helper-gitignore' (diff)
parentgit: use COPY_ARRAY and MOVE_ARRAY in handle_alias() (diff)
downloadgit-cabb145fe36c4e11ed9fd18b852b218e9407ac8b.tar.gz
git-cabb145fe36c4e11ed9fd18b852b218e9407ac8b.zip
Merge branch 'rs/alias-use-copy-array'
Code cleanup. * rs/alias-use-copy-array: git: use COPY_ARRAY and MOVE_ARRAY in handle_alias()
-rw-r--r--git.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/git.c b/git.c
index c1ee7124ed..ce6ab0ece2 100644
--- a/git.c
+++ b/git.c
@@ -369,8 +369,7 @@ static int handle_alias(int *argcp, const char ***argv)
die(_("alias '%s' changes environment variables.\n"
"You can use '!git' in the alias to do this"),
alias_command);
- memmove(new_argv - option_count, new_argv,
- count * sizeof(char *));
+ MOVE_ARRAY(new_argv - option_count, new_argv, count);
new_argv -= option_count;
if (count < 1)
@@ -385,7 +384,7 @@ static int handle_alias(int *argcp, const char ***argv)
REALLOC_ARRAY(new_argv, count + *argcp);
/* insert after command name */
- memcpy(new_argv + count, *argv + 1, sizeof(char *) * *argcp);
+ COPY_ARRAY(new_argv + count, *argv + 1, *argcp);
trace2_cmd_alias(alias_command, new_argv);
trace2_cmd_list_config();