diff options
| author | Siddharth Shrimali <r.siddharth.shrimali@gmail.com> | 2026-04-14 19:48:26 +0530 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-04-14 10:05:15 -0700 |
| commit | 6d0a3d91dd56467ba7749a5d28bb6c65ab0f8b49 (patch) | |
| tree | 23cb98e9166aaab8b2908bf5e059fb73b1df972a /t/t4013/diff.format-patch_--stdout_initial..main^ | |
| parent | 42148dafdf74f8458e7a710dcb982c0be0e40566 (diff) | |
| download | git-6d0a3d91dd56467ba7749a5d28bb6c65ab0f8b49.tar.gz git-6d0a3d91dd56467ba7749a5d28bb6c65ab0f8b49.zip | |
t7004: drop hardcoded tag count in invalid name test
The test 'trying to create a tag with a non-valid name should fail',
checked that exactly one tag existed in the repository before and after
attempting to create invalid tags.
As pointed out by Junio, this makes the test brittle by relying on a
specific global tag count. If future tests are added or removed before
this test, the expected state changes and this test would break for
completely unrelated reasons.
Since we already use 'test_must_fail' to guarantee that the invalid
tags are rejected by Git, counting the tags before and after is redundant.
Drop the 'test_line_count = 1' checks so the test doesn't rely on the
exact number of tags left behind by earlier tests.
Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4013/diff.format-patch_--stdout_initial..main^')
0 files changed, 0 insertions, 0 deletions