From f188e33e8a4112ce26cee94f5533f5459e62879f Mon Sep 17 00:00:00 2001
From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 10 Oct 2010 00:50:32 -0500
Subject: Makefile: dependencies for vcs-svn tests

The vcs-svn tests (test-treap.o et al) depend on the vcs-svn
headers for declarations and inline functions.  Declare the
dependency.  While at it, declare a dependency of the vcs-svn
objects (vcs-svn/string_pool.o et al) on $(LIB_H) to reflect use
within the vcs-svn library of git-compat-util.h and cache.h.

Without this change, tweaks to inline functions in those headers
do not provoke rebuilds of the corresponding tests[*], making
such changes unnecessarily difficult to test.

Before:

 $ touch vcs-svn/*.h && make test-treap
 $

After:

 $ touch vcs-svn/*.h && make test-treap
 CC test-treap.o
 LINK test-treap
 $

[*] unless COMPUTE_HEADER_DEPENDENCIES is enabled

Detected with "make CHECK_HEADER_DEPENDENCIES=1".

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 7a5fb699d1..7eb948d7c8 100644
--- a/Makefile
+++ b/Makefile
@@ -1823,6 +1823,8 @@ XDIFF_OBJS = xdiff/xdiffi.o xdiff/xprepare.o xdiff/xutils.o xdiff/xemit.o \
 	xdiff/xmerge.o xdiff/xpatience.o
 VCSSVN_OBJS = vcs-svn/string_pool.o vcs-svn/line_buffer.o \
 	vcs-svn/repo_tree.o vcs-svn/fast_export.o vcs-svn/svndump.o
+VCSSVN_TEST_OBJS = test-obj-pool.o test-string-pool.o \
+	test-line-buffer.o test-treap.o
 OBJECTS := $(GIT_OBJS) $(XDIFF_OBJS) $(VCSSVN_OBJS)
 
 dep_files := $(foreach f,$(OBJECTS),$(dir $f).depend/$(notdir $f).d)
@@ -1946,10 +1948,12 @@ xdiff-interface.o $(XDIFF_OBJS): \
 	xdiff/xinclude.h xdiff/xmacros.h xdiff/xdiff.h xdiff/xtypes.h \
 	xdiff/xutils.h xdiff/xprepare.h xdiff/xdiffi.h xdiff/xemit.h
 
-$(VCSSVN_OBJS): \
+$(VCSSVN_OBJS) $(VCSSVN_TEST_OBJS): $(LIB_H) \
 	vcs-svn/obj_pool.h vcs-svn/trp.h vcs-svn/string_pool.h \
 	vcs-svn/line_buffer.h vcs-svn/repo_tree.h vcs-svn/fast_export.h \
 	vcs-svn/svndump.h
+
+test-svn-fe.o: vcs-svn/svndump.h
 endif
 
 exec_cmd.s exec_cmd.o: EXTRA_CPPFLAGS = \
-- 
cgit v1.2.3

on value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/linux/log/?id=1e098dec61ba342c8cebbfdf0fcdcd9ce54f7fa1&amp;follow=1'>root</a>/<a href='/linux/log/tools?id=1e098dec61ba342c8cebbfdf0fcdcd9ce54f7fa1&amp;follow=1'>tools</a>/<a href='/linux/log/tools/debugging?id=1e098dec61ba342c8cebbfdf0fcdcd9ce54f7fa1&amp;follow=1'>debugging</a>/<a href='/linux/log/tools/debugging/kernel-chktaint?id=1e098dec61ba342c8cebbfdf0fcdcd9ce54f7fa1&amp;follow=1'>kernel-chktaint</a> (<a href='/linux/log/tools/debugging/kernel-chktaint?id=1e098dec61ba342c8cebbfdf0fcdcd9ce54f7fa1'>unfollow</a>)</div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/linux/log/tools/debugging/kernel-chktaint?id=1e098dec61ba342c8cebbfdf0fcdcd9ce54f7fa1&amp;showmsg=1&amp;follow=1'>Expand</a>)</th><th class='left'>Author</th><th class='left'>Files</th><th class='left'>Lines</th></tr>
<tr><td><span title='2023-04-27 16:21:32 -0700'>2023-04-27</span></td><td><a href='/linux/commit/drivers/cdx/cdx.c?id=d06f5a3f7140921ada47d49574ae6fa4de5e2a89&amp;follow=1'>cdx: fix build failure due to sysfs 'bus_type' argument needing to be const</a></td><td>Linus Torvalds</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+1</span></td></tr>
<tr><td><span title='2023-04-27 18:01:58 -0400'>2023-04-27</span></td><td><a href='/linux/commit/kernel/trace/ring_buffer.c?id=675751bb20634f981498c7d66161584080cc061e&amp;follow=1'>ring-buffer: Sync IRQ works before buffer destruction</a></td><td>Johannes Berg</td><td>1</td><td><span class='deletions'>-0</span>/<span class='insertions'>+4</span></td></tr>
<tr><td><span title='2023-04-27 13:45:31 -0700'>2023-04-27</span></td><td><a href='/linux/commit/.mailmap?id=d88f2f72ca89ead8743ee15e547274ba248e7c59&amp;follow=1'>mailmap: add entries for Paul Mackerras</a></td><td>Paul Mackerras</td><td>1</td><td><span class='deletions'>-0</span>/<span class='insertions'>+2</span></td></tr>
<tr><td><span title='2023-04-27 13:45:31 -0700'>2023-04-27</span></td><td><a href='/linux/commit/include/linux/libgcc.h?id=4f20b7471c57032860065591a17efd3325216bde&amp;follow=1'>libgcc: add forward declarations for generic library routines</a></td><td>Geert Uytterhoeven</td><td>1</td><td><span class='deletions'>-0</span>/<span class='insertions'>+7</span></td></tr>
<tr><td><span title='2023-04-27 13:42:16 -0700'>2023-04-27</span></td><td><a href='/linux/commit/mm/rmap.c?id=4d4b6d66db63ceed399f1fb1a4b24081d2590eb1&amp;follow=1'>mm,unmap: avoid flushing TLB in batch if PTE is inaccessible</a></td><td>Huang Ying</td><td>1</td><td><span class='deletions'>-4</span>/<span class='insertions'>+8</span></td></tr>
<tr><td><span title='2023-04-27 13:42:16 -0700'>2023-04-27</span></td><td><a href='/linux/commit/mm/shmem.c?id=01106e140835ff94fdef79d66f166b87b0c89824&amp;follow=1'>shmem: restrict noswap option to initial user namespace</a></td><td>Christian Brauner</td><td>1</td><td><span class='deletions'>-0</span>/<span class='insertions'>+4</span></td></tr>
<tr><td><span title='2023-04-27 13:42:16 -0700'>2023-04-27</span></td><td><a href='/linux/commit/mm/khugepaged.c?id=0175ab610c2df7c21d93e4bd63b4e67cfa86737c&amp;follow=1'>mm/khugepaged: fix conflicting mods to collapse_file()</a></td><td>Hugh Dickins</td><td>1</td><td><span class='deletions'>-22</span>/<span class='insertions'>+1</span></td></tr>
<tr><td><span title='2023-04-27 08:11:26 -0700'>2023-04-27</span></td><td><a href='/linux/commit/mm/mmap.c?id=7e7757876f258d99266e7b3c559639289a2a45fe&amp;follow=1'>mm/mremap: fix vm_pgoff in vma_merge() case 3</a></td><td>Vlastimil Babka</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+1</span></td></tr>
<tr><td><span title='2023-04-27 09:02:11 +1000'>2023-04-27</span></td><td><a href='/linux/commit/fs/xfs/libxfs/xfs_bmap.c?id=9419092fb2630c30e4ffeb9ef61007ef0c61827a&amp;follow=1'>xfs: fix livelock in delayed allocation at ENOSPC</a></td><td>Dave Chinner</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+0</span></td></tr>
<tr><td><span title='2023-04-26 23:43:16 +0200'>2023-04-26</span></td><td><a href='/linux/commit/kernel/time/timekeeping.c?id=158009f1b4a33bc0f354b994eea361362bd83226&amp;follow=1'>timekeeping: Fix references to nonexistent ktime_get_fast_ns()</a></td><td>Geert Uytterhoeven</td><td>1</td><td><span class='deletions'>-2</span>/<span class='insertions'>+2</span></td></tr>
<tr><td><span title='2023-04-26 08:58:34 -0700'>2023-04-26</span></td><td><a href='/linux/commit/arch/riscv/kernel/sys_riscv.c?id=b09313dd2e726fe5e1fa574cd73f5e326c6030a4&amp;follow=1'>RISC-V: hwprobe: Explicity check for -1 in vdso init</a></td><td>Andrew Jones</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+1</span></td></tr>
<tr><td><span title='2023-04-26 08:58:33 -0700'>2023-04-26</span></td><td><a href='/linux/commit/arch/riscv/kernel/sys_riscv.c?id=08dc107594681040587c23a097cfa678e51f5af2&amp;follow=1'>RISC-V: hwprobe: There can only be one first</a></td><td>Andrew Jones</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+3</span></td></tr>
<tr><td><span title='2023-04-26 07:30:52 -0700'>2023-04-26</span></td><td><a href='/linux/commit/arch/riscv/mm/init.c?id=26e7aacb83dfd04330673c5c9ac336560da52bb3&amp;follow=1'>riscv: Allow to downgrade paging mode from the command line</a></td><td>Alexandre Ghiti</td><td>10</td><td><span class='deletions'>-9</span>/<span class='insertions'>+154</span></td></tr>
<tr><td><span title='2023-04-26 07:29:02 -0700'>2023-04-26</span></td><td><a href='/linux/commit/Documentation/devicetree/bindings/riscv/cpus.yaml?id=d4dda690b44a5e36b4bf108c48177cef40c80d24&amp;follow=1'>dt-bindings: riscv: add sv57 mmu-type</a></td><td>Conor Dooley</td><td>1</td><td><span class='deletions'>-0</span>/<span class='insertions'>+1</span></td></tr>
<tr><td><span title='2023-04-26 09:10:02 -0400'>2023-04-26</span></td><td><a href='/linux/commit/kernel/trace/trace_output.c?id=adace4408252cc1c9913958d71e81a688af90a30&amp;follow=1'>tracing: Add missing spaces in trace_print_hex_seq()</a></td><td>Ken Lin</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+4</span></td></tr>
<tr><td><span title='2023-04-26 09:08:53 -0400'>2023-04-26</span></td><td><a href='/linux/commit/kernel/trace/ring_buffer.c?id=7c339fb4d8577792378136c15fde773cfb863cb8&amp;follow=1'>ring-buffer: Ensure proper resetting of atomic variables in ring_buffer_reset...</a></td><td>Tze-nan Wu</td><td>1</td><td><span class='deletions'>-3</span>/<span class='insertions'>+13</span></td></tr>
<tr><td><span title='2023-04-26 11:54:50 +0200'>2023-04-26</span></td><td><a href='/linux/commit/drivers/net/phy/Kconfig?id=9b78d919632b7149d311aaad5a977e4b48b10321&amp;follow=1'>net: phy: hide the PHYLIB_LEDS knob</a></td><td>Paolo Abeni</td><td>1</td><td><span class='deletions'>-3</span>/<span class='insertions'>+1</span></td></tr>
<tr><td><span title='2023-04-26 16:21:33 +1000'>2023-04-26</span></td><td><a href='/linux/commit/arch/powerpc/Kconfig?id=169f8997968ab620d750d9a45e15c5288d498356&amp;follow=1'>powerpc/64s: Disable pcrel code model on Clang</a></td><td>Nicholas Piggin</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+6</span></td></tr>
<tr><td><span title='2023-04-26 16:20:16 +1000'>2023-04-26</span></td><td><a href='/linux/commit/arch/powerpc/kernel/interrupt_64.S?id=0c993300d52bf5ce9b951c3b6b25d0d14acc49a9&amp;follow=1'>powerpc: Fix merge conflict between pcrel and copy_thread changes</a></td><td>Nicholas Piggin</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+1</span></td></tr>
<tr><td><span title='2023-04-25 21:58:42 -0700'>2023-04-25</span></td><td><a href='/linux/commit/arch/riscv/kernel/alternative.c?id=bb3f89487fd936df7cc5165bae37ca2669056c5c&amp;follow=1'>RISC-V: hwprobe: Remove __init on probe_vendor_features()</a></td><td>Evan Green</td><td>3</td><td><span class='deletions'>-6</span>/<span class='insertions'>+6</span></td></tr>
<tr><td><span title='2023-04-25 21:10:20 -0400'>2023-04-25</span></td><td><a href='/linux/commit/scripts/recordmcount.c?id=fa359d068574d29e7d2f0fdd0ebe4c6a12b5cfb9&amp;follow=1'>recordmcount: Fix memory leaks in the uwrite function</a></td><td>Hao Zeng</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+5</span></td></tr>
<tr><td><span title='2023-04-25 21:04:45 -0400'>2023-04-25</span></td><td><a href='/linux/commit/kernel/trace/trace_events_user.c?id=41d8fba193b36ac1208d8f8489390b93675fab7b&amp;follow=1'>tracing/user_events: Limit max fault-in attempts</a></td><td>Beau Belgrave</td><td>1</td><td><span class='deletions'>-14</span>/<span class='insertions'>+35</span></td></tr>
<tr><td><span title='2023-04-25 21:04:32 -0400'>2023-04-25</span></td><td><a href='/linux/commit/tools/testing/selftests/user_events/ftrace_test.c?id=97bbce89bfdec9219dfcb60cd62b815a97cb29cb&amp;follow=1'>tracing/user_events: Prevent same address and bit per process</a></td><td>Beau Belgrave</td><td>2</td><td><span class='deletions'>-1</span>/<span class='insertions'>+49</span></td></tr>
<tr><td><span title='2023-04-25 21:04:16 -0400'>2023-04-25</span></td><td><a href='/linux/commit/tools/testing/selftests/user_events/abi_test.c?id=17b439db21d5dbe70c419e982262621e5e6aba7f&amp;follow=1'>tracing/user_events: Ensure bit is cleared on unregister</a></td><td>Beau Belgrave</td><td>2</td><td><span class='deletions'>-3</span>/<span class='insertions'>+40</span></td></tr>
<tr><td><span title='2023-04-25 21:03:46 -0400'>2023-04-25</span></td><td><a href='/linux/commit/tools/testing/selftests/user_events/ftrace_test.c?id=cd98c93286a30cc4588dfd02453bec63c2f4acf4&amp;follow=1'>tracing/user_events: Ensure write index cannot be negative</a></td><td>Beau Belgrave</td><td>2</td><td><span class='deletions'>-0</span>/<span class='insertions'>+8</span></td></tr>
<tr><td><span title='2023-04-25 21:03:14 -0400'>2023-04-25</span></td><td><a href='/linux/commit/lib/seq_buf.c?id=96928d9032a7c34f12a88df879665562bcebf59a&amp;follow=1'>seq_buf: Add seq_buf_do_printk() helper</a></td><td>Sergey Senozhatsky</td><td>2</td><td><span class='deletions'>-0</span>/<span class='insertions'>+34</span></td></tr>
<tr><td><span title='2023-04-25 20:11:26 -0400'>2023-04-25</span></td><td><a href='/linux/commit/kernel/trace/trace_output.c?id=c7bdb07902e0b633795372665d0154e7267ecd0e&amp;follow=1'>tracing: Fix print_fields() for __dyn_loc/__rel_loc</a></td><td>Beau Belgrave</td><td>1</td><td><span class='deletions'>-4</span>/<span class='insertions'>+6</span></td></tr>
<tr><td><span title='2023-04-25 20:11:26 -0400'>2023-04-25</span></td><td><a href='/linux/commit/kernel/trace/trace_events_user.c?id=9872c07b14e5ad3e3a89a7fd43e9488072007118&amp;follow=1'>tracing/user_events: Set event filter_type from type</a></td><td>Beau Belgrave</td><td>1</td><td><span class='deletions'>-0</span>/<span class='insertions'>+3</span></td></tr>
<tr><td><span title='2023-04-25 20:11:26 -0400'>2023-04-25</span></td><td><a href='/linux/commit/kernel/trace/ring_buffer.c?id=625ed52717603f0de4c8b5cf163a3bba5cd9a362&amp;follow=1'>ring-buffer: Clearly check null ptr returned by rb_set_head_page()</a></td><td>Zheng Yejian</td><td>1</td><td><span class='deletions'>-2</span>/<span class='insertions'>+3</span></td></tr>
<tr><td><span title='2023-04-25 19:26:59 -0400'>2023-04-25</span></td><td><a href='/linux/commit/tools/tracing/rtla/src/timerlat_aa.c?id=82253a271aae9271fcf0aaa5e0ecc6dd38fb872b&amp;follow=1'>rtla/timerlat: Fix "Previous IRQ" auto analysis' line</a></td><td>Daniel Bristot de Oliveira</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+1</span></td></tr>
<tr><td><span title='2023-04-25 19:26:17 -0400'>2023-04-25</span></td><td><a href='/linux/commit/tools/tracing/rtla/src/timerlat_top.c?id=9fa48a2477de747b644c778a1e35d679cabcd917&amp;follow=1'>rtla/timerlat: Add auto-analysis only option</a></td><td>Daniel Bristot de Oliveira</td><td>2</td><td><span class='deletions'>-5</span>/<span class='insertions'>+51</span></td></tr>
<tr><td><span title='2023-04-25 19:24:28 -0400'>2023-04-25</span></td><td><a href='/linux/commit/kernel/trace/rv/rv.c?id=73e053cbd00ed890abfc812d6c602cbfa8d234dc&amp;follow=1'>rv: Remove redundant assignment to variable retval</a></td><td>Colin Ian King</td><td>1</td><td><span class='deletions'>-2</span>/<span class='insertions'>+0</span></td></tr>
<tr><td><span title='2023-04-25 17:02:13 -0400'>2023-04-25</span></td><td><a href='/linux/commit/tools/verification/rv/src/rv.c?id=54a0dffa62de0c91b406ff32082a121ccfa0d7f1&amp;follow=1'>rv: Fix addition on an uninitialized variable 'run'</a></td><td>Colin Ian King</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+1</span></td></tr>