linux/drivers/base/firmware_class.c, branch v3.11

firmware loader: fix another compile warning with PM_SLEEP unset

2013-06-26T04:04:22Z

This patch fixes another compiling warning with PM_SLEEP unset: drivers/base/firmware_class.c:221:29: warning: 'fw_lookup_buf' defined but not used [-Wunused-function] This time I do build kernel with both PM_SLEEP set and unset, and no warning found any more with the patch. Reported-by: Stephen Rothwell Signed-off-by: Ming Lei Signed-off-by: Greg Kroah-Hartman

firmware loader: fix compile warning with PM_SLEEP set

2013-06-21T21:09:47Z

This patch fixes the below compile warning: drivers/base/firmware_class.c:1254:12: warning: 'cache_firmware' defined but not used [-Wunused-function] static int cache_firmware(const char *fw_name) ^ drivers/base/firmware_class.c:1281:12: warning: 'uncache_firmware' defined but not used [-Wunused-function] static int uncache_firmware(const char *fw_name) ^ Reported-by: Stephen Rothwell Signed-off-by: Ming Lei Signed-off-by: Greg Kroah-Hartman

Merge branch 'driver-core-linus' into driver-core-next

2013-06-20T03:26:43Z

This resolves the merge issues with drivers/base/firmware_class.c Thanks to Ming Lei for the patch and hints on how to resolve it. Signed-off-by: Greg Kroah-Hartman

firmware loader: fix use-after-free by double abort

2013-06-18T17:41:55Z

fw_priv->buf is accessed in both request_firmware_load() and writing to sysfs file of 'loading' context, but not protected by 'fw_lock' entirely. The patch makes sure that access on 'fw_priv->buf' is protected by the lock. So fixes the double abort problem reported by nirinA raseliarison: http://lkml.org/lkml/2013/6/14/188 Reported-and-tested-by: nirinA raseliarison Cc: Guenter Roeck Cc: Bjorn Helgaas Cc: stable # 3.9 Signed-off-by: Ming Lei Signed-off-by: Greg Kroah-Hartman

firmware loader: simplify holding module for request_firmware

2013-06-06T19:41:57Z

module reference doesn't cover direct loading path, so this patch simply holds the module in the whole life time of request_firmware() to fix the problem. Signed-off-by: Ming Lei Signed-off-by: Greg Kroah-Hartman

firmware loader: don't export cache_firmware and uncache_firmware

2013-06-06T19:41:57Z

Looks no driver has the explict requirement for the two exported API, just don't export them anymore. Signed-off-by: Ming Lei Signed-off-by: Greg Kroah-Hartman

firmware loader: fix compile warning

2013-06-06T19:22:28Z

The commit ddf1f0648e8c("firmware loader: fix build failure with !CONFIG_FW_LOADER_USER_HELPER") introduces the below warning: drivers/base/firmware_class.c:921:13: warning: 'kill_requests_without_uevent' defined but not used [-Wunused-function] So fix it by defining kill_requests_without_uevent() only if CONFIG_PM_SLEEP is set. Reported-by: Stephen Rothwell Signed-off-by: Ming Lei Cc: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman

firmware loader: fix build failure with !CONFIG_FW_LOADER_USER_HELPER

2013-06-04T17:24:40Z

This patch fixes one build failure which is introduced by the patch below: driver core: firmware loader: kill FW_ACTION_NOHOTPLUG requests before suspend When CONFIG_FW_LOADER_USER_HELPER is unset, kill_requests_without_uevent() should be nop because no userspace loading is involved. Reported-by: kbuild test robot Signed-off-by: Ming Lei Signed-off-by: Greg Kroah-Hartman

driver core: firmware loader: kill FW_ACTION_NOHOTPLUG requests before suspend

2013-06-03T21:02:13Z

This patch kills the firmware loading requests of FW_ACTION_NOHOTPLUG before suspend to avoid blocking suspend because there is no timeout for these requests. Signed-off-by: Ming Lei Reviewed-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman

driver core: firmware loader: don't cache FW_ACTION_NOHOTPLUG firmware

2013-06-03T21:02:13Z

Generally there are only two drivers which don't need uevent to handle firmware loading, so don't cache these firmwares during suspend for these drivers since doing that may block firmware loading forever. Both the two drivers are involved in private firmware images, so they don't hit in direct loading too. Signed-off-by: Ming Lei Reviewed-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman