linux/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c, branch v6.16Mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
https://git.shady.money/linux/atom?h=v6.162025-06-24T14:37:32Zdrm/amd: Adjust output for discovery error handling2025-06-24T14:37:32ZMario Limonciellomario.limonciello@amd.com2025-06-17T18:30:52Zurn:sha1:73eab78721f7b85216f1ca8c7b732f13213b5b32
commit 017fbb6690c2 ("drm/amdgpu/discovery: check ip_discovery fw file
available") added support for reading an amdgpu IP discovery bin file
for some specific products. If it's not found then it will fallback to
hardcoded values. However if it's not found there is also a lot of noise
about missing files and errors.
Adjust the error handling to decrease most messages to DEBUG and to show
users less about missing files.
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Reported-by: Marcus Seyfarth <m.seyfarth@gmail.com>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4312
Tested-by: Marcus Seyfarth <m.seyfarth@gmail.com>
Fixes: 017fbb6690c2 ("drm/amdgpu/discovery: check ip_discovery fw file available")
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Link: https://lore.kernel.org/r/20250617183052.1692059-1-superm1@kernel.org
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 49f1f9f6c3c9febf8ba93f94a8d9c8d03e1ea0a1)
drm/amdgpu: Add more checks to discovery fetch2025-06-03T19:02:58ZLijo Lazarlijo.lazar@amd.com2025-05-29T10:27:44Zurn:sha1:719d84f8a812608fc0f7be18a96d7dee96eaf3ba
Add more checks for valid vram size and log error, if any.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu/ip_discovery: add missing ip_discovery fw2025-04-07T18:32:20ZFlora Cuiflora.cui@amd.com2025-03-26T12:06:13Zurn:sha1:2f6dd741cdcdadb9e125cc66d4fcfbe5ab92d36a
Signed-off-by: Flora Cui <flora.cui@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu/discovery: optionally use fw based ip discovery2025-03-21T16:16:36ZAlex Deucheralexander.deucher@amd.com2025-03-11T22:00:57Zurn:sha1:80a0e828293389358f7db56adcdcb22b28df5e11
On chips without native IP discovery support, use the fw binary
if available, otherwise we can continue without it.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Flora Cui <flora.cui@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu/discovery: use specific ip_discovery.bin for legacy asics2025-03-21T16:16:35ZFlora Cuiflora.cui@amd.com2025-03-11T05:44:08Zurn:sha1:25f602fbbcc8271f6e72211b54808ba21e677762
vega10/vega12/vega20/raven/raven2/picasso/arcturus/aldebaran
Signed-off-by: Flora Cui <flora.cui@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu/discovery: check ip_discovery fw file available2025-03-21T16:16:35ZFlora Cuiflora.cui@amd.com2025-02-27T02:39:27Zurn:sha1:017fbb6690c2245b1b4ef39b66c79d2990fe63dd
Signed-off-by: Flora Cui <flora.cui@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Use wafl version for xgmi2025-03-18T18:03:47ZLijo Lazarlijo.lazar@amd.com2025-02-25T05:59:47Zurn:sha1:6c11d4a87d5258f784699274b732bb5fe288475a
XGMI and WAFL share the same versions. Use WAFL version if XGMI version
is not present in discovery.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Asad Kamal <asad.kamal@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Remove unsupported xgmi versions2025-03-14T03:10:08ZLijo Lazarlijo.lazar@amd.com2025-02-06T12:03:46Zurn:sha1:b9e75bcb2b39e1202364d958ee4f27fd8a6f1313
XGMI v4.8.0 is not used in any SOCs. Remove the associated functions.
Also, ensure get_xgmi_info callback pointer is not NULL before calling
the function.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/amdgpu: add support for IP version 11.5.22025-02-13T02:05:49ZYing Liyingli12@amd.com2025-02-11T16:53:19Zurn:sha1:16a5a8fe6fb1868e5e19ba4e89e7b8caa37cc92c
This initializes drm/amd/amdgpu version 11.5.2
Signed-off-by: YING LI <yingli12@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: add discovery support for DCN IP version 3.6.02025-02-13T02:04:09ZTim Huangtim.huang@amd.com2025-01-02T06:30:35Zurn:sha1:76e0410fe07ea236477adf7468636a9def0769bd
Add discovery entry for DCN IP version 3.6.0.
Signed-off-by: Tim Huang <tim.huang@amd.com>
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>