linux/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c, branch v6.8Mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
https://git.shady.money/linux/atom?h=v6.82023-10-13T15:32:41Zdrm/amdgpu: Avoid FRU EEPROM access on APU2023-10-13T15:32:41ZLijo Lazarlijo.lazar@amd.com2023-10-12T07:33:22Zurn:sha1:a8558fce7ad0c60be5f652ad76adef9a387465bb
FRU EEPROM access is not valid for APU devices.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Yang Wang <kevinyang.wang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Documentation/amdgpu: Add FRU attribute details2023-10-09T20:52:25ZLijo Lazarlijo.lazar@amd.com2023-10-04T13:16:06Zurn:sha1:b3e73b5a8f8ae3f585abd756416b089f82578ef2
Add documentation for the newly added manufacturer and fru_id attributes
in sysfs.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add more FRU field information2023-10-09T20:52:17ZLijo Lazarlijo.lazar@amd.com2023-10-04T13:02:02Zurn:sha1:ac6b1f275f17ba9873ec677979ba240d9d952413
Add support to read Manufacturer Name and FRU File Id fields. Also add
sysfs device attributes for external usage.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Refactor FRU product information2023-10-09T20:52:08ZLijo Lazarlijo.lazar@amd.com2023-10-04T10:30:47Zurn:sha1:8a2b51392ac4a5ecc310c6dddd6cb70c71f0ddeb
Keep FRU related information together in a separate structure.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: enable FRU device for SMU v13.0.62023-10-09T20:51:58ZYang Wangkevinyang.wang@amd.com2023-09-21T07:25:43Zurn:sha1:be2e8aca0602296fef90330c5564ac1967e641eb
v1:
enable GFX v9.4.3 FRU device to query board information.
v2:
use MP1 version to identify different asic
Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Fix a memory leak2023-09-26T21:00:23ZLuben Tuikovluben.tuikov@amd.com2023-09-22T21:21:21Zurn:sha1:9ed630c5c4b3d3d6e333ae629c1a9c4be6745f74
Fix a memory leak in amdgpu_fru_get_product_info().
Cc: Alex Deucher <Alexander.Deucher@amd.com>
Reported-by: Yang Wang <kevinyang.wang@amd.com>
Fixes: 0dbf2c562625 ("drm/amdgpu: Interpret IPMI data for product information (v2)")
Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
Reviewed-by: Alex Deucher <Alexander.Deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add FRU sysfs nodes only if needed2023-08-09T13:45:55ZLijo Lazarlijo.lazar@amd.com2023-08-04T13:02:54Zurn:sha1:7957ec80ef97e983bb87782757c9dd74c34acc27
Create sysfs nodes for FRU data only if FRU data is available. Move the
logic to FRU specific file.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Remove else after return in 'is_fru_eeprom_supported'2023-07-25T17:47:26ZSrinivasan Shanmugamsrinivasan.shanmugam@amd.com2023-07-23T06:34:13Zurn:sha1:ce83aa7bad8327830a1b907b4544e302ef09c2cf
Expressions under 'else' branch under case 'CHIP_SIENNA_CICHLID' in
function 'is_fru_eeprom_supported' are executed whenever the expression
in 'if' is False. Otherwise, return from case occurs. Therefore, there
is no need in 'else', and it has been removed.
Fixes the following:
WARNING: else is not generally useful after a break or return
+ return false;
+ } else {
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd: Avoid reading the VBIOS part number twice2023-07-21T20:52:24ZMario Limonciellomario.limonciello@amd.com2023-07-18T18:02:58Zurn:sha1:adf64e214280a0230af0638c1825b3812421c958
The VBIOS part number is read both in amdgpu_atom_parse() as well
as in atom_get_vbios_pn() and stored twice in the `struct atom_context`
structure. Remove the first unnecessary read and move the `pr_info`
line from that read into the second.
v2: squash in unused variable removal
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Check if fru_addr is not NULL (v2)2022-12-14T21:48:00ZLuben Tuikovluben.tuikov@amd.com2022-12-12T17:04:42Zurn:sha1:28afcb0ad54c858d0f426b340e88e0277a375597
Always check if fru_addr is not NULL. This commit also fixes a "smatch"
warning.
v2: Add a Fixes tag.
Cc: Alex Deucher <Alexander.Deucher@amd.com>
Cc: Dan Carpenter <error27@gmail.com>
Cc: kernel test robot <lkp@intel.com>
Cc: AMD Graphics <amd-gfx@lists.freedesktop.org>
Fixes: afbe5d1e4bd7c7 ("drm/amdgpu: Bug-fix: Reading I2C FRU data on newer ASICs")
Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
Reviewed-by: Kent Russell <kent.russell@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>