linux/drivers/misc/eeprom, branch v4.8

eeprom: at24: tweak the loop_until_timeout() macro

2016-07-18T18:07:54Z

loop_until_timeout() replaced a do {} while loop in the at24 driver with a for loop which, under certain circumstances (such as heavy load or low value of the write_timeout argument), can lead to the code in the loop never being executed. Make sure that at least one iteration of the code enclosed within loop_until_timeout() is always executed. Suggested-by: Wolfram Sang Signed-off-by: Bartosz Golaszewski Signed-off-by: Wolfram Sang

eeprom: at24: add support for at24mac series

2016-07-17T17:58:00Z

Add a new read function to the at24 driver allowing to retrieve the factory-programmed mac address embedded in chips from the at24mac family. These chips can be instantiated similarily to the at24cs family, except that there's no way of having access to both the serial number and the mac address at the same time - the user must instantiate either an at24cs or at24mac device as both special memory areas are accessible on the same slave address. Signed-off-by: Bartosz Golaszewski Signed-off-by: Wolfram Sang

eeprom: at24: support reading the serial number for 24csxx

2016-07-17T17:57:30Z

The chips from the at24cs family have two memory areas - a regular read-write block and a read-only area containing the serial number. The latter is visible on a different slave address (the address of the rw memory block + 0x08). In order to access both blocks the user needs to instantiate a regular at24c device for the rw block address and a corresponding at24cs device on the serial number block address. Add a function that allows to access the serial number and assign it to at24->read_func if the chip allows serial number read operations and the driver was passed the relevant flag for this device. Signed-off-by: Bartosz Golaszewski Signed-off-by: Wolfram Sang

eeprom: at24: split at24_eeprom_write() into specialized functions

2016-07-17T17:41:54Z

Split at24_eeprom_write() into three smaller functions - one for the i2c operations and two for the smbus extensions (separate routines for block and byte transfers). Assign them in at24_probe() depending on the bus capabilities. Also: in order to avoid duplications move code adjusting the count argument into a separate function and use it for i2c and smbus block writes (no need for a roll-over for byte writes as we're always writing one byte). Signed-off-by: Bartosz Golaszewski Signed-off-by: Wolfram Sang

eeprom: at24: split at24_eeprom_read() into specialized functions

2016-07-17T17:41:54Z

Split at24_eeprom_read() into two smaller functions - one for the i2c operations and one for the smbus extensions. Assign them in at24_probe() depending on the bus capabilities. Also: in order to avoid duplications move the comments related to offset calculations above the at24_translate_offset() routine. Signed-off-by: Bartosz Golaszewski Signed-off-by: Wolfram Sang

eeprom: at24: hide the read/write loop behind a macro

2016-07-17T17:41:54Z

Before splitting the read/write routines into smaller, more specialized functions, unduplicate some code in advance. Use a 'for' loop instead of 'do while' when waiting for the previous write to complete and hide it behind a macro. Signed-off-by: Bartosz Golaszewski Signed-off-by: Wolfram Sang

eeprom: at24: call read/write functions via function pointers

2016-07-17T17:41:54Z

The first step in simplifying the read and write functions is to call them via function pointers stored in at24_data. When we eventually split the routines into smaller ones (depending on whether they use smbus or i2c operations) we'll simply assign them to said pointers instead of checking the flags at runtime every time we read/write. Signed-off-by: Bartosz Golaszewski Signed-off-by: Wolfram Sang

eeprom: at24: coding style fixes

2016-07-17T17:41:54Z

Align the arguments in broken lines with the arguments list's opening brackets and make checkpatch.pl happy by converting 'unsigned' into 'unsigned int'. Signed-off-by: Bartosz Golaszewski Signed-off-by: Wolfram Sang

eeprom: at24: move at24_read() below at24_eeprom_write()

2016-07-17T17:41:54Z

In preparation for splitting at24_eeprom_write() & at24_eeprom_read() into smaller, specialized routines move at24_read() below, so that it won't be intertwined with the low-level EEPROM accessors. Signed-off-by: Bartosz Golaszewski Signed-off-by: Wolfram Sang

eeprom: at24: improve the device_id table readability

2016-07-17T17:41:54Z

As part of the preparation for introducing support for more chips, improve the readability of the device table by separating columns with tabs. Signed-off-by: Bartosz Golaszewski Signed-off-by: Wolfram Sang