linux/drivers/mtd/ubi/attach.c, branch v4.5

UBI: drop null test before destroy functions

2015-10-03T18:36:10Z

Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; @@ -if (x != NULL) \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); // Signed-off-by: Julia Lawall Signed-off-by: Richard Weinberger

UBI: Fastmap: Fall back to scanning mode after ECC error

2015-03-26T22:03:15Z

If we encounter an uncorrectable ECC error while scanning for the fastmap UBI must not fail hard. Instead fall back to scanning mode. Reported-by: Alexander Block Signed-off-by: Richard Weinberger

UBI: Fastmap: Make self_check_eba() depend on fastmap self checking

2015-03-26T21:46:05Z

...instead of generic self checking. Signed-off-by: Richard Weinberger

UBI: Remove alloc_ai() slab name from parameter list

2015-03-26T21:45:57Z

There is always exactly one ubi_attach_info object allocated, therefore we don't have to care about the name. Signed-off-by: Richard Weinberger

UBI: Fastmap: Fix memory leak while attaching

2015-03-26T21:45:57Z

Currently we leak a few ubi_ainf_pebs while attaching. Signed-off-by: Richard Weinberger

UBI: account for bitflips in both the VID header and data

2015-03-26T11:07:17Z

We are completely discarding the earlier value of 'bitflips', which could reflect a bitflip found in ubi_io_read_vid_hdr(). Let's use the bitwise OR of header and data 'bitflip' statuses instead. Coverity CID #1226856 Cc: stable Signed-off-by: Brian Norris Signed-off-by: Richard Weinberger

UBI: Extend UBI layer debug/messaging capabilities

2014-11-07T10:08:51Z

If there is more then one UBI device mounted, there is no way to distinguish between messages from different UBI devices. Add device number to all ubi layer message types. The R/O block driver messages were replaced by pr_* since ubi_device structure is not used by it. Amended a bit by Artem. Signed-off-by: Tanya Brokhman Signed-off-by: Artem Bityutskiy

UBI: fix error return code

2014-01-02T15:16:01Z

Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Julia Lawall Reviewed-by: Richard Weinberger

UBI: simplify image sequence test

2013-10-03T16:42:50Z

The test: if (!a && b) a = b; can be symplified in: if (!a) a = b; And there's no need to test if ubi->image_seq is not null, because if it is, it is set to image_seq. So, we just test if image_seq is not null. Signed-off-by: Richard Genoud Signed-off-by: Richard Weinberger Signed-off-by: Artem Bityutskiy

UBI: Call scan_all() with correct offset in error case

2013-10-03T16:42:49Z

If we find an invalid fastmap we have to scan from the very beginning. Otherwise we leak the first 64 PEBs. Reported-and-tested-by: Richard Genoud Signed-off-by: Richard Weinberger Signed-off-by: Artem Bityutskiy