linux/drivers/net/ipa/ipa_clock.c, branch v5.12

net: ipa: use dev_err_probe() in ipa_clock.c

2021-02-13T00:54:17Z

When initializing the IPA core clock and interconnects, it's possible we'll get an EPROBE_DEFER error. This isn't really an error, it's just means we need to be re-probed later. Use dev_err_probe() to report the error rather than dev_err(). This avoids polluting the log with these "error" messages. Signed-off-by: Alex Elder Signed-off-by: David S. Miller

net: ipa: allow arbitrary number of interconnects

2021-01-18T19:51:06Z

Currently we assume that the IPA hardware has exactly three interconnects. But that won't be guaranteed for all platforms, so allow any number of interconnects to be specified in the configuration data. For each platform, define an array of interconnect data entries (still associated with the IPA clock structure), and record the number of entries initialized in that array. Loop over all entries in this array when initializing, enabling, disabling, or tearing down the set of interconnects. With this change we no longer need the ipa_interconnect_id enumerated type, so get rid of it. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: clean up interconnect initialization

2021-01-18T19:51:06Z

Pass an the address of an IPA interconnect structure and its configuration data to ipa_interconnect_init_one() and have that function initialize all the structure's fields. Change the function to simply return an error code. Introduce ipa_interconnect_exit_one() to encapsulate the cleanup of an IPA interconnect structure. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: add interconnect name to configuration data

2021-01-18T19:51:05Z

Add the name to the configuration data for each interconnect. Use this information rather than a constant string during initialization. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: store average and peak interconnect bandwidth

2021-01-18T19:51:05Z

Add fields in the ipa_interconnect structure to hold the average and peak bandwidth values for the interconnect. Pass the configuring data for interconnects to ipa_interconnect_init() so these values can be recorded, and use them when enabling the interconnects. There's no longer any need to keep a copy of the interconnect data after initialization. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: introduce an IPA interconnect structure

2021-01-18T19:51:05Z

Rather than having separate pointers for the memory, imem, and config interconnect paths, maintain an array of ipa_interconnect structures each of which contains a pointer to a path. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: don't return an error from ipa_interconnect_disable()

2021-01-18T19:51:05Z

If disabling interconnects fails there's not a lot we can do. The only two callers of ipa_interconnect_disable() ignore the return value, so just give the function a void return type. Print an error message if disabling any of the interconnects is not successful. Return (and print) only the first error seen. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: rename interconnect settings

2021-01-18T19:51:05Z

Use "bandwidth" rather than "rate" in describing the average and peak values to use for IPA interconnects. They should have been named that way to begin with. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski

net: ipa: fix interconnect enable bug

2020-12-23T19:35:48Z

When the core clock rate and interconnect bandwidth specifications were moved into configuration data, a copy/paste bug was introduced, causing the memory interconnect bandwidth to be set three times rather than enabling the three different interconnects. Fix this bug. Fixes: 91d02f9551501 ("net: ipa: use config data for clocking") Signed-off-by: Alex Elder Reviewed-by: Georgi Djakov Link: https://lore.kernel.org/r/20201222151613.5730-1-elder@linaro.org Signed-off-by: Jakub Kicinski

net: ipa: use config data for clocking

2020-11-21T02:45:00Z

Stop assuming a fixed IPA core clock rate and interconnect bandwidths. Use the configuration data defined for these things instead. Get rid of the previously-used constants. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski