linux/drivers/net/ipa, branch v6.13

net: Switch back to struct platform_driver::remove()

2024-10-04T23:39:57Z

After commit 0edb555a65d1 ("platform: Make platform_driver::remove() return void") .remove() is (again) the right callback to implement for platform drivers. Convert all platform drivers below drivers/net after the previous conversion commits apart from the wireless drivers to use .remove(), with the eventual goal to drop struct platform_driver::remove_new(). As .remove() and .remove_new() have the same prototypes, conversion is done by just changing the structure member name in the driver initializer. Signed-off-by: Uwe Kleine-König Reviewed-by: Andrew Lunn Reviewed-by: Sergey Ryazanov Acked-by: Stefan Schmidt Signed-off-by: Jakub Kicinski

net: ipa: make use of dev_err_cast_probe()

2024-08-29T18:41:05Z

Using dev_err_cast_probe() to simplify the code. Signed-off-by: Hongbo Li Link: https://patch.msgid.link/20240828121551.3696520-1-lihongbo22@huawei.com Signed-off-by: Jakub Kicinski

net: ipa: allocate dummy net_device dynamically

2024-04-24T11:00:16Z

Embedding net_device into structures prohibits the usage of flexible arrays in the net_device structure. For more details, see the discussion at [1]. Un-embed the net_device from the private struct by converting it into a pointer. Then use the leverage the new alloc_netdev_dummy() helper to allocate and initialize dummy devices. [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ Signed-off-by: Breno Leitao Signed-off-by: David S. Miller

net: ipa: kill ipa_version_supported()

2024-04-23T11:08:08Z

The only place ipa_version_supported() is called is in the probe function. The version comes from the match data. Rather than checking the version validity separately, just consider anything that has match data to be supported. Signed-off-by: Alex Elder Signed-off-by: Paolo Abeni

net: ipa: fix two minor ipa_cmd problems

2024-04-23T11:08:08Z

In "ipa_cmd.h", ipa_cmd_data_valid() is declared, but that function does not exist. So delete that declaration. Also, for some reason ipa_cmd_init() never gets called. It isn't really critical--it just validates that some memory offsets and a size can be represented in some register fields, and they won't fail with current data. Regardless, call the function in ipa_probe(). Signed-off-by: Alex Elder Signed-off-by: Paolo Abeni

net: ipa: fix two bogus argument names

2024-04-23T11:08:08Z

In "ipa_endpoint.h", two function declarations have bogus argument names. Fix these. Signed-off-by: Alex Elder Signed-off-by: Paolo Abeni

net: ipa: make ipa_table_hash_support() a real function

2024-04-23T11:08:08Z

With the exception of ipa_table_hash_support(), nothing defined in "ipa_table.h" requires the full definition of the IPA structure. Change that function to be a "real" function rather than an inline, to avoid requring the IPA structure to be defined. Signed-off-by: Alex Elder Signed-off-by: Paolo Abeni

net: ipa: remove unneeded FILT_ROUT_HASH_EN definitions

2024-04-23T11:08:08Z

The FILT_ROUT_HASH_EN register is only used for IPA v4.2. There, routing and filter table hashing are not supported, and so the register must be written to disable the feature. No other version uses this register, so its definition can be removed. If we need to use these some day (for example, explicitly enable the feature) this commit can be reverted. Signed-off-by: Alex Elder Signed-off-by: Paolo Abeni

net: ipa: call device_init_wakeup() earlier

2024-04-23T11:08:08Z

Currently, enabling wakeup for the IPA device doesn't occur until the setup phase of initialization (in ipa_power_setup()). There is no need to delay doing that, however. We can conveniently do it during the config phase, in ipa_interrupt_config(), where we enable power management wakeup mode for the IPA interrupt. Moving the device_init_wakeup() out of ipa_power_setup() leaves that function empty, so it can just be eliminated. Similarly, rearrange all of the matching inverse calls, disabling device wakeup in ipa_interrupt_deconfig() and removing that function as well. Signed-off-by: Alex Elder Signed-off-by: Paolo Abeni

net: ipa: only enable the SUSPEND IPA interrupt when needed

2024-04-23T11:08:08Z

Only enable the SUSPEND IPA interrupt type when at least one endpoint has that interrupt enabled. Signed-off-by: Alex Elder Signed-off-by: Paolo Abeni