Mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ https://git.shady.money/linux/atom?h=v5.10 2020-10-21T18:22:08Z 2020-10-21T18:22:08Z Linus Torvalds torvalds@linux-foundation.org 2020-10-21T18:22:08Z urn:sha1:b7769c45b8d95f1c70b9dec38c8de8ad229ce222 Pull RTC updates from Alexandre Belloni: "A new driver this cycle is making the bulk of the changes and the rx8010 driver has been rework to use the modern APIs. Summary: Subsystem: - new generic DT properties: aux-voltage-chargeable, trickle-voltage-millivolt New driver: - Microcrystal RV-3032 Drivers: - ds1307: use aux-voltage-chargeable - r9701, rx8010: modernization of the driver - rv3028: fix clock output, trickle resistor values, RAM configuration registers" * tag 'rtc-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux: (50 commits) rtc: r9701: set range rtc: r9701: convert to devm_rtc_allocate_device rtc: r9701: stop setting RWKCNT rtc: r9701: remove useless memset rtc: r9701: stop setting a default time rtc: r9701: remove leftover comment rtc: rv3032: Add a driver for Microcrystal RV-3032 dt-bindings: rtc: rv3032: add RV-3032 bindings dt-bindings: rtc: add trickle-voltage-millivolt rtc: rv3028: ensure ram configuration registers are saved rtc: rv3028: factorize EERD bit handling rtc: rv3028: fix trickle resistor values rtc: rv3028: fix clock output support rtc: mt6397: Remove unused member dev rtc: rv8803: simplify the return expression of rv8803_nvram_write rtc: meson: simplify the return expression of meson_vrtc_probe rtc: rx8010: rename rx8010_init_client() to rx8010_init() rtc: ds1307: enable rx8130's backup battery, make it chargeable optionally rtc: ds1307: consider aux-voltage-chargeable rtc: ds1307: store previous charge default per chip ... 2020-10-19T20:48:55Z Alexandre Belloni alexandre.belloni@bootlin.com 2020-10-15T19:11:35Z urn:sha1:35331b506f6c67a0b4042fac1ae2785cef9ac8c3 Set range and remove the set_time check. This is a classic BCD RTC. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201015191135.471249-6-alexandre.belloni@bootlin.com 2020-10-19T20:48:55Z Alexandre Belloni alexandre.belloni@bootlin.com 2020-10-15T19:11:34Z urn:sha1:dfe13cf2ae5a7cdb131e61a8aae4fb27cd379bd4 This allows further improvement of the driver. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201015191135.471249-5-alexandre.belloni@bootlin.com 2020-10-19T20:48:55Z Alexandre Belloni alexandre.belloni@bootlin.com 2020-10-15T19:11:33Z urn:sha1:8b34134907e7d70b8b51fa56ecd4f8c50c46692c tm_wday is never checked for validity and it is not read back in r9701_get_datetime. Avoid setting it to stop tripping static checkers: drivers/rtc/rtc-r9701.c:109 r9701_set_datetime() error: undefined (user controlled) shift '1 << dt->tm_wday' Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201015191135.471249-4-alexandre.belloni@bootlin.com 2020-10-19T20:48:55Z Alexandre Belloni alexandre.belloni@bootlin.com 2020-10-15T19:11:32Z urn:sha1:2a8f3380c9e50a36b99a92febfd78f7c7afd29b0 The RTC core already sets to zero the struct rtc_tie it passes to the driver, avoid doing it a second time. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201015191135.471249-3-alexandre.belloni@bootlin.com 2020-10-19T20:48:55Z Alexandre Belloni alexandre.belloni@bootlin.com 2020-10-15T19:11:31Z urn:sha1:7390bec4ed5d510d1a637257ff75e9ab49030411 It doesn't make sense to set the RTC to a default value at probe time. Let the core handle invalid date and time. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201015191135.471249-2-alexandre.belloni@bootlin.com 2020-10-19T20:48:55Z Alexandre Belloni alexandre.belloni@bootlin.com 2020-10-15T19:11:30Z urn:sha1:92c6dcfbd1eb803d4669c82b3d8a0fcbb803e3f9 Commit 22652ba72453 ("rtc: stop validating rtc_time in .read_time") removed the code but not the associated comment. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201015191135.471249-1-alexandre.belloni@bootlin.com 2020-10-19T20:47:56Z Alexandre Belloni alexandre.belloni@bootlin.com 2020-10-13T14:41:10Z urn:sha1:2eeaa532accab8810ca9fe21f52d149713561235 New driver for the Microcrystal RV-3032, including support for: - Date/time - Alarms - Low voltage detection - Trickle charge - Trimming - Clkout - RAM - EEPROM - Temperature sensor Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201013144110.1942218-3-alexandre.belloni@bootlin.com 2020-10-15T10:09:35Z Alexandre Belloni alexandre.belloni@bootlin.com 2020-10-09T15:31:01Z urn:sha1:024e6f3dce9ef0bc61acc5b93bb1eba491e4f8d0 If RV3028_CTRL1_EERD is not set (this is the default), the RTC will refresh the RAM configuration registers from the EEPROM at midnight. It is necessary to save the RAM registers back to EEPROM after modifying them. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201009153101.721149-4-alexandre.belloni@bootlin.com 2020-10-15T10:09:35Z Alexandre Belloni alexandre.belloni@bootlin.com 2020-10-09T15:31:00Z urn:sha1:de0ad60e79e1ce563223b3fddf03fc19f606c6d4 Both rv3028_eeprom_write and rv3028_eeprom_read enable EERD before sending commands to the EEPROM and restore it afterwards. Factorize this code. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201009153101.721149-3-alexandre.belloni@bootlin.com