staging: ccree: remove ccree staging driver copy

2018-03-14T12:02:48Z

The ccree driver is now in the cryptodev tree, so remove it from drivers/staging as it's no longer needed here. Based on a patch from Gilad, but the mailing list didn't like it :( Signed-off-by: Gilad Ben-Yossef Signed-off-by: Greg Kroah-Hartman

staging: ccree: fixed pointer signedness warnings.

2018-02-16T14:33:02Z

The driver uses a mixture of signed and unsigned integer variables for holding arrays lengths and indices, which gives rise to the following sparse warnings when the addresses of signed variables are passed to functions expecting pointers to unsigned integers: drivers/staging/ccree/cc_buffer_mgr.c:1050:46: warning: incorrect type in argument 4 (different signedness) drivers/staging/ccree/cc_buffer_mgr.c:1050:46: expected unsigned int [usertype] *lbytes drivers/staging/ccree/cc_buffer_mgr.c:1050:46: got int * drivers/staging/ccree/cc_buffer_mgr.c:1083:62: warning: incorrect type in argument 7 (different signedness) drivers/staging/ccree/cc_buffer_mgr.c:1083:62: expected unsigned int [usertype] *lbytes drivers/staging/ccree/cc_buffer_mgr.c:1083:62: got int * drivers/staging/ccree/cc_buffer_mgr.c:1092:46: warning: incorrect type in argument 4 (different signedness) drivers/staging/ccree/cc_buffer_mgr.c:1092:46: expected unsigned int [usertype] *lbytes drivers/staging/ccree/cc_buffer_mgr.c:1092:46: got int * drivers/staging/ccree/cc_buffer_mgr.c:1120:49: warning: incorrect type in argument 4 (different signedness) drivers/staging/ccree/cc_buffer_mgr.c:1120:49: expected unsigned int [usertype] *src_last_bytes drivers/staging/ccree/cc_buffer_mgr.c:1120:49: got int * drivers/staging/ccree/cc_buffer_mgr.c:1121:49: warning: incorrect type in argument 5 (different signedness) drivers/staging/ccree/cc_buffer_mgr.c:1121:49: expected unsigned int [usertype] *dst_last_bytes drivers/staging/ccree/cc_buffer_mgr.c:1121:49: got int * drivers/staging/ccree/cc_buffer_mgr.c:1124:49: warning: incorrect type in argument 2 (different signedness) drivers/staging/ccree/cc_buffer_mgr.c:1124:49: expected unsigned int [usertype] *src_last_bytes drivers/staging/ccree/cc_buffer_mgr.c:1124:49: got int * drivers/staging/ccree/cc_buffer_mgr.c:1125:44: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_buffer_mgr.c:1125:44: expected unsigned int [usertype] *dst_last_bytes drivers/staging/ccree/cc_buffer_mgr.c:1125:44: got int * drivers/staging/ccree/cc_cipher.c:697:67: warning: incorrect type in argument 6 (different signedness) drivers/staging/ccree/cc_cipher.c:697:67: expected unsigned int *seq_size drivers/staging/ccree/cc_cipher.c:697:67: got int * drivers/staging/ccree/cc_cipher.c:700:31: warning: incorrect type in argument 8 (different signedness) drivers/staging/ccree/cc_cipher.c:700:31: expected unsigned int *seq_size drivers/staging/ccree/cc_cipher.c:700:31: got int * drivers/staging/ccree/cc_hash.c:480:57: warning: incorrect type in argument 6 (different signedness) drivers/staging/ccree/cc_hash.c:480:57: expected unsigned int *seq_size drivers/staging/ccree/cc_hash.c:480:57: got int * drivers/staging/ccree/cc_hash.c:530:57: warning: incorrect type in argument 6 (different signedness) drivers/staging/ccree/cc_hash.c:530:57: expected unsigned int *seq_size drivers/staging/ccree/cc_hash.c:530:57: got int * drivers/staging/ccree/cc_hash.c:1305:43: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_hash.c:1305:43: expected unsigned int *seq_size drivers/staging/ccree/cc_hash.c:1305:43: got int * drivers/staging/ccree/cc_hash.c:1307:43: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_hash.c:1307:43: expected unsigned int *seq_size drivers/staging/ccree/cc_hash.c:1307:43: got int * drivers/staging/ccree/cc_hash.c:1317:69: warning: incorrect type in argument 6 (different signedness) drivers/staging/ccree/cc_hash.c:1317:69: expected unsigned int *seq_size drivers/staging/ccree/cc_hash.c:1317:69: got int * drivers/staging/ccree/cc_hash.c:1390:43: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_hash.c:1390:43: expected unsigned int *seq_size drivers/staging/ccree/cc_hash.c:1390:43: got int * drivers/staging/ccree/cc_hash.c:1393:43: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_hash.c:1393:43: expected unsigned int *seq_size drivers/staging/ccree/cc_hash.c:1393:43: got int * drivers/staging/ccree/cc_hash.c:1404:69: warning: incorrect type in argument 6 (different signedness) drivers/staging/ccree/cc_hash.c:1404:69: expected unsigned int *seq_size drivers/staging/ccree/cc_hash.c:1404:69: got int * drivers/staging/ccree/cc_hash.c:1469:43: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_hash.c:1469:43: expected unsigned int *seq_size drivers/staging/ccree/cc_hash.c:1469:43: got int * drivers/staging/ccree/cc_hash.c:1472:43: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_hash.c:1472:43: expected unsigned int *seq_size drivers/staging/ccree/cc_hash.c:1472:43: got int * drivers/staging/ccree/cc_hash.c:1483:69: warning: incorrect type in argument 6 (different signedness) drivers/staging/ccree/cc_hash.c:1483:69: expected unsigned int *seq_size drivers/staging/ccree/cc_hash.c:1483:69: got int * drivers/staging/ccree/cc_aead.c:2011:37: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_aead.c:2011:37: expected unsigned int *seq_size drivers/staging/ccree/cc_aead.c:2011:37: got int * drivers/staging/ccree/cc_aead.c:2017:45: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_aead.c:2017:45: expected unsigned int *seq_size drivers/staging/ccree/cc_aead.c:2017:45: got int * drivers/staging/ccree/cc_aead.c:2020:45: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_aead.c:2020:45: expected unsigned int *seq_size drivers/staging/ccree/cc_aead.c:2020:45: got int * drivers/staging/ccree/cc_aead.c:2024:44: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_aead.c:2024:44: expected unsigned int *seq_size drivers/staging/ccree/cc_aead.c:2024:44: got int * drivers/staging/ccree/cc_aead.c:2026:44: warning: incorrect type in argument 3 (different signedness) drivers/staging/ccree/cc_aead.c:2026:44: expected unsigned int *seq_size drivers/staging/ccree/cc_aead.c:2026:44: got int * This patch fixes those warnings by converting those signed variables to unsigned as follows: * changed the types of a number of index and length variables from signed to unsigned integer types. * changed the return-types of a couple of functions that return length values which are assigned to one of these variables from signed to unsigned integer types. Signed-off-by: Jeremy Sowden Signed-off-by: Greg Kroah-Hartman

staging: ccree: Fix missing blank line after declaration

2018-01-25T12:11:33Z

Fix the following warning found by checkpatch.pl WARNING: Missing a blank line after declarations + struct cc_cipher_handle *blkcipher_handle = drvdata->blkcipher_handle; + if (blkcipher_handle) { Signed-off-by: Kamal Heib Signed-off-by: Greg Kroah-Hartman

staging: ccree: fix memory leaks in cc_ivgen_init

2018-01-15T14:50:35Z

The current error exit path in function cc_ivgen_init via label 'out' free's resources from the drvdata->ivgen_handle context. However, drvdata->ivgen_handle has not been assigned to the context ivgen_ctx at this point, so the resources are not freed. Fix this by setting drvdata->ivgen_handle to ivgen_ctx as early as possible so that the clean up error exit return path can free the resources. Detected by CoveritScan, CID#1463795 ("Resource leak") Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman

staging: ccree: remove redundant dev_err call in init_cc_resources()

2018-01-15T14:50:35Z

There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Signed-off-by: Greg Kroah-Hartman

staging: ccree: don't break lines unnecessarily

2018-01-15T14:50:35Z

These lines are less than 80 characters so we don't need to break them up into chunks. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

staging: ccree: dma mask is type u64

2018-01-09T15:02:18Z

The dma mask var was defined as dma_addr_t but should be u64. This showed as a sparse warning when building for 32 bit. Fix it by changing type to u64 and drop the cast. Signed-off-by: Gilad Ben-Yossef Signed-off-by: Greg Kroah-Hartman

staging: ccree: make stub function static inline

2018-01-09T15:02:18Z

The debugfs interface defines stub function if debugfs is not enabled, which were missing the 'static inline' qualifiers causing sparse warnings. Signed-off-by: Gilad Ben-Yossef Signed-off-by: Greg Kroah-Hartman

staging: ccree: add missing include

2018-01-09T15:02:18Z

Add the missing include of include file with function declarations. Signed-off-by: Gilad Ben-Yossef Signed-off-by: Greg Kroah-Hartman

staging: ccree: remove unneeded includes

2018-01-09T15:01:35Z

Remove include files not needed for compilation. Signed-off-by: Gilad Ben-Yossef Signed-off-by: Greg Kroah-Hartman

linux/drivers/staging/ccree, branch master

staging: ccree: remove ccree staging driver copy

staging: ccree: fixed pointer signedness warnings.

staging: ccree: Fix missing blank line after declaration

staging: ccree: fix memory leaks in cc_ivgen_init

staging: ccree: remove redundant dev_err call in init_cc_resources()

staging: ccree: don't break lines unnecessarily

staging: ccree: dma mask is type u64

staging: ccree: make stub function static inline

staging: ccree: add missing include

staging: ccree: remove unneeded includes