linux/drivers/staging/dgap, branch v3.19

Drivers:staging:dgap: Added a blank line after declaration

2014-11-26T22:00:22Z

This patch fixes the checkpatch.pl warning: WARNING:Missing a blank line after declaration Signed-off-by: Anjana Sasindran Signed-off-by: Greg Kroah-Hartman

staging: dgap: introducing find_board_by_major()

2014-11-07T17:30:22Z

use find_board_by_major function instead of getting a brd from static arrary. Becasue tty's major number doesn't start zero and we can find a brd from dgap_board[]. Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove useless variables for saving tty's major

2014-11-07T17:30:22Z

The board_t has a tty_struct(serial_driver and print_driver) that has a major number. When major number is compared in dgap_tty_open(), just use brd->serial_driver{print_driver}->major. Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman

staging: dgap: fix memory leak caused by double allocation of tty_structs

2014-11-07T17:30:22Z

The tty_struct of serial_driver and print_driver were getting allocated twice. One is allocated in tty_alloc_driver(), the other is in dgap_tty_register(). So remove these in dgap_tty_register(). Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman

staging: dgap: set tty's flags by tty_alloc_driver()

2014-11-07T17:30:21Z

tty's flags can be set by calling tty_alloc_driver(). Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove unnecessary function

2014-11-05T22:49:14Z

The dgap_init_global() initialize the dgap_board that is a global variable as static and dgap_poll_timer. But init_timer() is called twice in dgap_start() and dgap_board doesn't need to be initialized to NULL. Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman

staging: dgap: re-arrange functions for removing forward declarations

2014-11-04T00:24:56Z

Re-arrange the functions for removing forward declarations. Signed-off-by: Daeseok Youn Tested-by: Mark Hounschell Signed-off-by: Greg Kroah-Hartman

staging: dgap: Remove useless cast on NULL

2014-10-30T20:09:15Z

Cast on NULL to a pointer type is not required. This patch removes NULL casted to some pointer type. The sematic patch used is: @r@ type T; @@ - (T *)NULL + NULL Build tested it. Signed-off-by: Tapasweni Pathak Reviewed-by: Josh Triplett Signed-off-by: Greg Kroah-Hartman

staging: dgap: Remove useless cast on void pointer

2014-10-30T20:05:46Z

void pointers do not need to be cast to other pointer types. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Build tested it. Signed-off-by: Tapasweni Pathak Signed-off-by: Greg Kroah-Hartman

staging: dgap: Use unsigned for loop index

2014-10-28T08:19:02Z

The following semantic patch is used to do this @r exists@ // find anything that might decrement the variable identifier i; expression E; position p; @@ int i@p; ... ( &i | i-- | --i | i-=E | i+=E ) @x disable decl_init@ identifier r.i; expression E; position p1 != r.p; @@ ( volatile int i = 0; | volatile int i; | + unsigned int i@p1 = 0; | + unsigned int i@p1; ) <... when != i = E ( i = 0 | i = 1 ) ...> Signed-off-by: Tapasweni Pathak Signed-off-by: Greg Kroah-Hartman