linux/drivers/staging/dgap, branch v4.2

Staging: dgap: dgap: Fixed spelling errors

2015-05-31T02:40:14Z

Fixed comment spelling errors Signed-off-by: Colin Cronin Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove unused code

2015-05-10T13:17:50Z

dgap_sindex() is being only called from dgap_getword() which searches for either ' ' or '\t' or '\n'. this part of the code with '^' at the beginning is never used. Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman

staging: dgap: use remove function

2015-05-10T13:12:09Z

the remove callback will be called in two cases, 1) if the driver is removed and 2) if the pci device is removed. as of now all the board cleanups were being done in the module unload section so if the module is unloaded everything works. But if the pci device is removed then the loaded driver will be left in an inconsistent state. So moved the cleanups in the remove callback and since there was no reference of dgap_driver in remove_one(), so had to define the pci_driver in the function. Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman

staging: dgap: move function before remove

2015-05-10T13:12:09Z

move the cleanup function before the remove call as the next patch of the series is going to use that. Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman

Staging: dgap: Use setup_timer to combine initialization

2015-03-16T15:17:31Z

The function setup_timer combines the initialization of a timer with the initialization of the timer's function and data fields. So, this patch combines the multiline code for timer initialization using the function setup_timer. This issue is identified via coccinelle script. @@ expression E1, E2, E3; type T; @@ - init_timer(&E1); ... ( - E1.function = E2; ... - E1.data = (T)E3; + setup_timer(&E1, E2, (T)E3); | - E1.data = (T)E3; ... - E1.function = E2; + setup_timer(&E1, E2, (T)E3); | - E1.function = E2; + setup_timer(&E1, E2, 0); ) Signed-off-by: Somya Anand Signed-off-by: Greg Kroah-Hartman

Staging: dgap: Remove unused variable

2015-03-09T12:30:40Z

This patch removes variable that was used to store only the return value of a function call. The issue was detected and resolved using the following coccinelle script: @@ expression ret; identifier f; @@ -ret = +return f(...); -return ret; Signed-off-by: Haneen Mohammed Reviewed-by: Daniel Baluta Signed-off-by: Greg Kroah-Hartman

staging: dgap: Avoid name collision

2015-03-07T01:06:30Z

Building for ARM64 leads to the following build warning: In file included from drivers/staging/dgap/dgap.c:66:0: drivers/staging/dgap/dgap.h:124:0: warning: "PCI_IO_SIZE" redefined #define PCI_IO_SIZE 0x00200000 ^ In file included from ./arch/arm64/include/asm/page.h:66:0, from include/linux/mm_types.h:15, from include/linux/sched.h:27, from ./arch/arm64/include/asm/compat.h:25, from ./arch/arm64/include/asm/stat.h:23, from include/linux/stat.h:5, from include/linux/module.h:10, from drivers/staging/dgap/dgap.c:47: ./arch/arm64/include/asm/memory.h:39:0: note: this is the location of the previous definition #define PCI_IO_SIZE SZ_16M ^ Use PCI_IO_SIZE_DGAP to avoid the name collision. Reported-by: Olof's autobuilder Signed-off-by: Fabio Estevam Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove unused variable

2015-03-02T00:57:36Z

This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; ... when != len when strict -len = +return f(...); -return len; Signed-off-by: Aya Mahfouz Signed-off-by: Greg Kroah-Hartman

staging: dgap: fix "if" statement that always evaluates to true

2015-01-25T12:08:13Z

cppcheck warning: (warnning) Logical disjunction always evaluates to true Reported-by: David Binderman Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman

staging: dgap: use gotos for handling error in dgap_remap()

2015-01-18T00:10:48Z

Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman