linux/drivers/staging/dgap, branch v4.3

Staging:dgap :Compression of lines for immediate return

2015-07-31T23:14:53Z

This patch compresses two lines into a single line if immediate return statement is found. Remove variable rc as it is no longer needed. It is done using script Coccinelle. And coccinelle uses the following semantic patch for this compression function: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by: Shraddha Barke Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove duplicate code

2015-07-16T17:19:55Z

Remove the duplicate code of dgap_remove_one() and dgap_stop(). Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman

staging: dgap: new arguments to dgap_stop

2015-07-16T17:19:55Z

In a later patch we will remove the duplicate codes. But the code also needs to execute dgap_remove_driver_sysfiles() if it is being called from dgap_remove_one() but if being called fron the error path of the dgap_init_module() then the sysfiles should not be removed. Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman

staging: dgap: rearrange function

2015-07-16T17:19:55Z

Relocate the function dgap_stop() so that in a later patch we can remove the duplicate codes between dgap_stop() and dgap_remove_one(). Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman

staging: dgap: fix error path

2015-07-16T17:19:55Z

The code in dgap_stop() is almost a duplicate of the code that will be executed on pci_unregister_driver(). So the error code was stopping and unregistering everything twice. Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman

Staging: dgap: dgap: Fixed spelling errors

2015-05-31T02:40:14Z

Fixed comment spelling errors Signed-off-by: Colin Cronin Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove unused code

2015-05-10T13:17:50Z

dgap_sindex() is being only called from dgap_getword() which searches for either ' ' or '\t' or '\n'. this part of the code with '^' at the beginning is never used. Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman

staging: dgap: use remove function

2015-05-10T13:12:09Z

the remove callback will be called in two cases, 1) if the driver is removed and 2) if the pci device is removed. as of now all the board cleanups were being done in the module unload section so if the module is unloaded everything works. But if the pci device is removed then the loaded driver will be left in an inconsistent state. So moved the cleanups in the remove callback and since there was no reference of dgap_driver in remove_one(), so had to define the pci_driver in the function. Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman

staging: dgap: move function before remove

2015-05-10T13:12:09Z

move the cleanup function before the remove call as the next patch of the series is going to use that. Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman

Staging: dgap: Use setup_timer to combine initialization

2015-03-16T15:17:31Z

The function setup_timer combines the initialization of a timer with the initialization of the timer's function and data fields. So, this patch combines the multiline code for timer initialization using the function setup_timer. This issue is identified via coccinelle script. @@ expression E1, E2, E3; type T; @@ - init_timer(&E1); ... ( - E1.function = E2; ... - E1.data = (T)E3; + setup_timer(&E1, E2, (T)E3); | - E1.data = (T)E3; ... - E1.function = E2; + setup_timer(&E1, E2, (T)E3); | - E1.function = E2; + setup_timer(&E1, E2, 0); ) Signed-off-by: Somya Anand Signed-off-by: Greg Kroah-Hartman