linux/drivers/staging/nvec/nvec.c, branch v4.1

Staging: nvec: use !x instead of x == NULL

2015-03-16T15:28:47Z

Functions like devm_kzalloc, kmalloc_array, devm_ioremap, usb_alloc_urb, alloc_netdev return NULL as a return value on failure. Generally, When NULL represents failure, !x is commonly used. This patch cleans up the tests on the results of these functions, thereby using !x instead of x == NULL or NULL == x. This is done via following coccinelle script: @prob_7@ identifier x; statement S; @@ ( x = devm_kzalloc(...); | x = usb_alloc_urb(...); | x = kmalloc_array(...); | x = devm_ioremap(...); | x = alloc_netdev(...); ) ... - if(NULL == x) + if(!x) S Further we have used isomorphism characteristics of coccinelle to indicate x == NULL and NULL == x are equivalent. This is done via following iso script. Expression @ is_null @ expression X; @@ X == NULL <=> NULL == X Signed-off-by: Somya Anand Signed-off-by: Greg Kroah-Hartman

staging: nvec: specify a platform-device base id

2015-01-21T02:31:09Z

commit 6e3f62f079 (mfd: core: Fix platform-device id generation) modified the computation of the mfd cell id. Negative numbers forbit the specification of cell ids as we do. Fix this for now by specifying a base of 0 instead. In the long run, this may be changed to automatic cell ids (base -2). Reported-by: Misha Komarovskiy Signed-off-by: Marc Dietrich Signed-off-by: Greg Kroah-Hartman

Staging: nvec: Fixed a typo

2015-01-17T23:18:33Z

Fixed a typo in nvec.c file Signed-off-by: Gustavo A. R. Silva Signed-off-by: Greg Kroah-Hartman

staging: nvec: drop owner assignment from platform_drivers

2014-10-20T14:21:41Z

A platform_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang

staging/nvec: Use platform_get_irq()

2014-07-31T00:18:47Z

As opposed to platform_get_resource(), the platform_get_irq() function has special code to handle driver probe deferral when booting using DT and where an interrupt provider hasn't been registered yet. While this is unlikely to become an issue for nvec, platform_get_irq() is the recommended way to get at interrupts. Signed-off-by: Thierry Reding Acked-by: Marc Dietrich Signed-off-by: Greg Kroah-Hartman

staging/nvec: Do not pass resource to mfd_add_devices()

2014-07-31T00:18:47Z

The mfd_add_devices() function takes a struct resource * as fifth argument, but the nvec driver passes in a void __iomem *. The driver gets away with it because none of the subdevices ever directly access the registers. Since subdevices never need to access the registers we can simply pass NULL instead. Signed-off-by: Thierry Reding Acked-by: Marc Dietrich Signed-off-by: Greg Kroah-Hartman

staging/nvec: Remove double const qualifier

2014-07-21T21:20:50Z

The SIMPLE_DEV_PM_OPS macro already uses the const qualifier, so there's no need to repeat it. Signed-off-by: Thierry Reding Acked-by: Marc Dietrich Signed-off-by: Greg Kroah-Hartman

staging: nvec: remove unneccessary 'out of memory' message

2014-07-09T19:14:06Z

Fix the following warning reported by checkpatch.pl: WARNING: Possible unnecessary 'out of memory' message 811: FILE: drivers/staging/nvec/nvec.c:811 Signed-off-by: Pawel Lebioda Acked-by: Marc Dietrich Reviewed-by: Thierry Reding Signed-off-by: Greg Kroah-Hartman

staging: nvec: remove unnecessary 'else' after 'return' statement

2014-07-09T19:14:06Z

Fix the following warning reported by checkpatch.pl: WARNING: else is not generally useful after a break or return 235: FILE: drivers/staging/nvec/nvec.c:235 Signed-off-by: Pawel Lebioda Acked-by: Marc Dietrich Reviewed-by: Thierry Reding Signed-off-by: Greg Kroah-Hartman

Staging:nvec: fix quoted string split across lines

2014-03-07T23:19:36Z

Fix checkpatch.pl issues with quoted string split across lines in nvec.c Signed-off-by: Ebru Akagunduz Acked-by: Paul E. McKenney Signed-off-by: Greg Kroah-Hartman