linux/drivers/video/fbdev, branch v6.7Mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
https://git.shady.money/linux/atom?h=v6.72023-11-10T08:16:02Zfbdev: fsl-diu-fb: mark wr_reg_wa() static2023-11-10T08:16:02ZArnd Bergmannarnd@arndb.de2023-11-08T12:58:42Zurn:sha1:a5035c81847430dfa3482807b07325f29e9e8c09
wr_reg_wa() is not an appropriate name for a global function, and doesn't need
to be global anyway, so mark it static and avoid the warning:
drivers/video/fbdev/fsl-diu-fb.c:493:6: error: no previous prototype for 'wr_reg_wa' [-Werror=missing-prototypes]
Fixes: 0d9dab39fbbe ("powerpc/5121: fsl-diu-fb: fix issue with re-enabling DIU area descriptor")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: amifb: Convert to platform remove callback returning void2023-11-10T08:16:02ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-09T22:01:54Zurn:sha1:dce217780270300db7931d0fd73796aa64fea237
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: amifb: Mark driver struct with __refdata to prevent section mismatch warning2023-11-10T08:16:02ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-09T22:01:53Zurn:sha1:67e1ab5bb58a787809772eba14e7e758c765e2fd
As described in the added code comment, a reference to .exit.text is ok
for drivers registered via module_platform_driver_probe(). Make this
explicit to prevent a section mismatch warning.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: hyperv_fb: fix uninitialized local variable use2023-11-10T06:34:19ZArnd Bergmannarnd@arndb.de2023-11-08T14:58:13Zurn:sha1:cca202a5e59578247cd7f0496056884f5c9cc338
When CONFIG_SYSFB is disabled, the hyperv_fb driver can now run into
undefined behavior on a gen2 VM, as indicated by this smatch warning:
drivers/video/fbdev/hyperv_fb.c:1077 hvfb_getmem() error: uninitialized symbol 'base'.
drivers/video/fbdev/hyperv_fb.c:1077 hvfb_getmem() error: uninitialized symbol 'size'.
Since there is no way to know the actual framebuffer in this configuration,
just return an allocation failure here, which should avoid the build
warning and the undefined behavior.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202311070802.YCpvehaz-lkp@intel.com/
Fixes: a07b50d80ab6 ("hyperv: avoid dependency on screen_info")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/tpd12s015: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:18:03Zurn:sha1:2e2389ca5d7efd2f029b138d78e38200d5ba125b
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/tfp410: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:18:02Zurn:sha1:a23f29d057d034c77bd6689a5c328a6933255bf4
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/sharp-ls037v7dw01: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:18:01Zurn:sha1:b0d61e8c04965373b74d719a460153cb700dab80
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/opa362: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:18:00Zurn:sha1:fe83fc52db06aa0632e53b3b27184e26971b555d
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/hdmi: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:17:59Zurn:sha1:34948a36a4bbf583bf39b5c9783aa9e872c7910d
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/dvi: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:17:58Zurn:sha1:ebfb1334cf430ef36059c5bed35e9cfbab23ff11
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>