linux/lib/test_xarray.c, branch v5.0

XArray tests: Check mark 2 gets squashed

2019-01-14T19:50:34Z

We do not currently check that the loop in xas_squash_marks() doesn't have an off-by-one error in it. It didn't, but a patch which introduced an off-by-one error wasn't caught by any existing test. Switch the roles of XA_MARK_1 and XA_MARK_2 to catch that bug. Reported-by: Cyrill Gorcunov Signed-off-by: Matthew Wilcox

XArray: Honour reserved entries in xa_insert

2019-01-07T03:12:58Z

xa_insert() should treat reserved entries as occupied, not as available. Also, it should treat requests to insert a NULL pointer as a request to reserve the slot. Add xa_insert_bh() and xa_insert_irq() for completeness. Signed-off-by: Matthew Wilcox

XArray: Permit storing 2-byte-aligned pointers

2019-01-07T03:12:57Z

On m68k, statically allocated pointers may only be two-byte aligned. This clashes with the XArray's method for tagging internal pointers. Permit storing these pointers in single slots (ie not in multislots). Signed-off-by: Matthew Wilcox

XArray: Change xa_for_each iterator

2019-01-07T02:24:43Z

There were three problems with this API: 1. It took too many arguments; almost all users wanted to iterate over every element in the array rather than a subset. 2. It required that 'index' be initialised before use, and there's no realistic way to make GCC catch that. 3. 'index' and 'entry' were the opposite way round from every other member of the XArray APIs. So split it into three different APIs: xa_for_each(xa, index, entry) xa_for_each_start(xa, index, entry, start) xa_for_each_marked(xa, index, entry, filter) Signed-off-by: Matthew Wilcox

XArray tests: Add RCU locking

2019-01-07T02:24:43Z

0day picked up that I'd forgotten to add locking to this new test. Signed-off-by: Matthew Wilcox

XArray: Fix xa_alloc when id exceeds max

2018-12-13T19:07:33Z

Specifying a starting ID greater than the maximum ID isn't something attempted very often, but it should fail. It was succeeding due to xas_find_marked() returning the wrong error state, so add tests for both xa_alloc() and xas_find_marked(). Fixes: b803b42823d0 ("xarray: Add XArray iterators") Signed-off-by: Matthew Wilcox

XArray tests: Check iterating over multiorder entries

2018-12-06T14:25:33Z

There was no bug here, but there was no test coverage for this scenario. Signed-off-by: Matthew Wilcox

XArray tests: Handle larger indices more elegantly

2018-12-06T14:25:15Z

xa_mk_value() only handles values up to LONG_MAX. I successfully hid that inside xa_store_index() and xa_erase_index(), but it turned out I also needed it for testing xa_alloc() on 32-bit machines. So extract xa_mk_index() from the above two functions, and convert the non-constant users of xa_mk_value() to xa_mk_index(). Signed-off-by: Matthew Wilcox

XArray tests: Add missing locking

2018-11-19T14:41:11Z

Lockdep caught me being sloppy in the test suite and failing to lock the XArray appropriately. Reported-by: kernel test robot Signed-off-by: Matthew Wilcox

XArray tests: Correct some 64-bit assumptions

2018-11-16T21:38:45Z

The test-suite caught these two mistakes when compiled for 32-bit. I had only been running the test-suite in 64-bit mode. Signed-off-by: Matthew Wilcox