linux/lib/xarray.c, branch v4.20

XArray: Fix xa_alloc when id exceeds max

2018-12-13T19:07:33Z

Specifying a starting ID greater than the maximum ID isn't something attempted very often, but it should fail. It was succeeding due to xas_find_marked() returning the wrong error state, so add tests for both xa_alloc() and xas_find_marked(). Fixes: b803b42823d0 ("xarray: Add XArray iterators") Signed-off-by: Matthew Wilcox

XArray: Correct xa_store_range

2018-11-16T21:27:28Z

The explicit '64' should have been BITS_PER_LONG, but while looking at this code I realised I meant to use __ffs(), not ilog2(). Signed-off-by: Matthew Wilcox

XArray: Fix Documentation

2018-11-05T21:38:10Z

Minor fixes. Signed-off-by: Matthew Wilcox

XArray: Handle NULL pointers differently for allocation

2018-11-05T21:38:09Z

For allocating XArrays, it makes sense to distinguish beteen erasing an entry and storing NULL. Storing NULL keeps the index allocated with a NULL pointer associated with it while xa_erase() frees the index. Some existing IDR users rely on this ability. Signed-off-by: Matthew Wilcox

XArray: Unify xa_store and __xa_store

2018-11-05T21:38:09Z

Saves around 115 bytes on a tinyconfig build and reduces the amount of code duplication in the XArray implementation. Signed-off-by: Matthew Wilcox

XArray: Turn xa_erase into an exported function

2018-11-05T21:38:09Z

Make xa_erase() take the spinlock and then call __xa_erase(), but make it out of line since it's such a common function. Signed-off-by: Matthew Wilcox

XArray: Unify xa_cmpxchg and __xa_cmpxchg

2018-11-05T21:38:08Z

xa_cmpxchg() was one of the largest functions in the xarray implementation. By turning it into a wrapper and having the callers take the lock (like several other functions), we save 160 bytes on a tinyconfig build and reduce the duplication in xarray.c. Signed-off-by: Matthew Wilcox

XArray: Regularise xa_reserve

2018-11-05T21:38:08Z

The xa_reserve() function was a little unusual in that it attempted to be callable for all kinds of locking scenarios. Make it look like the other APIs with __xa_reserve, xa_reserve_bh and xa_reserve_irq variants. Signed-off-by: Matthew Wilcox

XArray: Export __xa_foo to non-GPL modules

2018-11-05T19:56:58Z

Without this, it's not possible to use static inlines like xa_store_bh() and xa_erase_irq(). Signed-off-by: Matthew Wilcox

XArray: Fix xa_for_each with a single element at 0

2018-11-05T19:56:46Z

The following sequence of calls would result in an infinite loop in xa_find_after(): xa_store(xa, 0, x, GFP_KERNEL); index = 0; xa_for_each(xa, entry, index, ULONG_MAX, XA_PRESENT) { } xa_find_after() was confusing the situation where we found no entry in the tree with finding a multiorder entry, so it would look for the successor entry forever. Just check for this case explicitly. Includes a few new checks in the test suite to be sure this doesn't reappear. Signed-off-by: Matthew Wilcox