linux/net/ipv4, branch v2.6.16

[NETFILTER]: arp_tables: fix NULL pointer dereference

2006-03-13T04:40:43Z

The check is wrong and lets NULL-ptrs slip through since !IS_ERR(NULL) is true. Coverity #190 Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[IPV4/6]: Fix UFO error propagation

2006-03-13T04:39:40Z

When ufo_append_data fails err is uninitialized, but returned back. Strangely gcc doesn't notice it. Coverity #901 and #902 Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[TCP]: tcp_highspeed: fix AIMD table out-of-bounds access

2006-03-13T04:39:39Z

Covertiy #547 Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[TCP]: Fix tcp_tso_should_defer() when limit>=65536

2006-03-12T02:51:49Z

That's >= a full sized TSO frame, so we should always return 0 in that case. Based upon a report and initial patch from Lachlan Andrew, final patch suggested by Herbert Xu. Signed-off-by: David S. Miller

[NETFILTER] ip_queue: Fix wrong skb->len == nlmsg_len assumption

2006-03-07T22:56:12Z

The size of the skb carrying the netlink message is not equivalent to the length of the actual netlink message due to padding. ip_queue matches the length of the payload against the original packet size to determine if packet mangling is desired, due to the above wrong assumption arbitary packets may not be mangled depening on their original size. Signed-off-by: Thomas Graf Signed-off-by: David S. Miller

[NETFILTER]: Restore {ipt,ip6t,ebt}_LOG compatibility

2006-02-27T21:04:17Z

The nfnetlink_log infrastructure changes broke compatiblity of the LOG targets. They currently use whatever log backend was registered first, which means that if ipt_ULOG was loaded first, no messages will be printed to the ring buffer anymore. Restore compatiblity by using the old log functions by default and only use the nf_log backend if the user explicitly said so. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[IPSEC]: Kill post_input hook and do NAT-T in esp_input directly

2006-02-27T21:00:40Z

The only reason post_input exists at all is that it gives us the potential to adjust the checksums incrementally in future which we ought to do. However, after thinking about it for a bit we can adjust the checksums without using this post_input stuff at all. The crucial point is that only the inner-most NAT-T SA needs to be considered when adjusting checksums. What's more, the checksum adjustment comes down to a single u32 due to the linearity of IP checksums. We just happen to have a spare u32 lying around in our skb structure :) When ip_summed is set to CHECKSUM_NONE on input, the value of skb->csum is currently unused. All we have to do is to make that the checksum adjustment and voila, there goes all the post_input and decap structures! I've left in the decap data structures for now since it's intricately woven into the sec_path stuff. We can kill them later too. Signed-off-by: Herbert Xu Signed-off-by: David S. Miller

[IPSEC] esp: Kill unnecessary block and indentation

2006-02-27T21:00:01Z

We used to keep sg on the stack which is why the extra block was useful. We've long since stopped doing that so let's kill the block and save some indentation. Signed-off-by: Herbert Xu Signed-off-by: David S. Miller

[IPSEC]: Use TOS when doing tunnel lookups

2006-02-24T00:19:26Z

We should use the TOS because it's one of the routing keys. It also means that we update the correct routing cache entry when PMTU occurs. Signed-off-by: Herbert Xu Signed-off-by: David S. Miller

[IPV4]: Fix garbage collection of multipath route entries

2006-02-24T00:10:52Z

When garbage collecting route cache entries of multipath routes in rt_garbage_collect(), entries were deleted from the hash bucket 'i' while holding a spin lock on bucket 'k' resulting in a system hang. Delete entries, if any, from bucket 'k' instead. Signed-off-by: Suresh Bhogavilli Signed-off-by: David S. Miller