linux/net/netfilter/nf_queue.c, branch v2.6.26

Remove duplicated unlikely() in IS_ERR()

2008-04-29T15:06:25Z

Some drivers have duplicated unlikely() macros. IS_ERR() already has unlikely() in itself. This patch cleans up such pointless code. Signed-off-by: Hirofumi Nakagawa Acked-by: David S. Miller Acked-by: Jeff Garzik Cc: Paul Clements Cc: Richard Purdie Cc: Alessandro Zummo Cc: David Brownell Cc: James Bottomley Cc: Michael Halcrow Cc: Anton Altaparmakov Cc: Al Viro Cc: Carsten Otte Cc: Patrick McHardy Cc: Paul Mundt Cc: Jaroslav Kysela Cc: Takashi Iwai Acked-by: Mike Frysinger Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

[NETFILTER]: Replate direct proc_fops assignment with proc_create call.

2008-03-27T23:55:53Z

This elliminates infamous race during module loading when one could lookup proc entry without proc_fops assigned. Signed-off-by: Denis V. Lunev Signed-off-by: David S. Miller

[NETFILTER]: nf_queue: don't return error when unregistering a non-existant handler

2008-03-10T23:45:05Z

Commit ce7663d84: [NETFILTER]: nfnetlink_queue: don't unregister handler of other subsystem changed nf_unregister_queue_handler to return an error when attempting to unregister a queue handler that is not identical to the one passed in. This is correct in case we really do have a different queue handler already registered, but some existing userspace code always does an unbind before bind and aborts if that fails, so try to be nice and return success in that case. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NETFILTER]: constify nf_afinfo

2008-01-28T22:59:05Z

Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NETFILTER]: nf_queue: clean up error paths

2008-01-28T22:56:16Z

Move duplicated error handling to end of function and add a helper function to release the device and module references from the queue entry. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NETFILTER]: {nfnetlink,ip,ip6}_queue: kill issue_verdict

2008-01-28T22:56:15Z

Now that issue_verdict doesn't need to free the queue entries anymore, all it does is disable local BHs and call nf_reinject. Move the BH disabling to the okfn invocation in nf_reinject and kill the issue_verdict functions. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NETFILTER]: nf_queue: move list_head/skb/id to struct nf_info

2008-01-28T22:56:14Z

Move common fields for queue management to struct nf_info and rename it to struct nf_queue_entry. The avoids one allocation/free per packet and simplifies the code a bit. Alternatively we could add some private room at the tail, but since all current users use identical structs this seems easier. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NETFILTER]: nf_queue: move queueing related functions/struct to seperate header

2008-01-28T22:56:10Z

Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NETFILTER]: nf_queue: remove unused data pointer

2008-01-28T22:56:10Z

Remove the data pointer from struct nf_queue_handler. It has never been used and is useless for the only handler that really matters, nfnetlink_queue, since the handler is shared between all instances. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NETFILTER]: nf_queue: make queue_handler const

2008-01-28T22:56:09Z

Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller