linux/scripts/kallsyms.c, branch v5.5Mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
https://git.shady.money/linux/atom?h=v5.52019-12-14T06:53:04Zscripts/kallsyms: fix offset overflow of kallsyms_relative_base2019-12-14T06:53:04ZMasahiro Yamadamasahiroy@kernel.org2019-12-09T03:51:48Zurn:sha1:fd2ab2f6610b2bec70e626c38de8a4242fa88e48
Since commit 5e5c4fa78745 ("scripts/kallsyms: shrink table before
sorting it"), kallsyms_relative_base can be larger than _text, which
causes overflow when building the 32-bit kernel.
https://lkml.org/lkml/2019/12/7/156
This is because _text is, unless --all-symbols is specified, now
trimmed from the symbol table before record_relative_base() is called.
Handle the offset signedness also for kallsyms_relative_base. Introduce
a new helper, output_address(), to reduce the code duplication.
Fixes: 5e5c4fa78745 ("scripts/kallsyms: shrink table before sorting it")
Reported-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kallsyms: remove redundant initializers2019-11-25T12:07:05ZMasahiro Yamadayamada.masahiro@socionext.com2019-11-23T16:04:44Zurn:sha1:831362fc317ae60413879deacdcc9617d9ce9e20
These are set to zero without the explicit initializers.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: put check_symbol_range() calls close together2019-11-25T12:06:49ZMasahiro Yamadayamada.masahiro@socionext.com2019-11-23T16:04:43Zurn:sha1:d44270fc976b6c3b9e742e398580e4af8c69f7bd
Put the relevant code close together.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: make check_symbol_range() void function2019-11-25T12:06:37ZMasahiro Yamadayamada.masahiro@socionext.com2019-11-23T16:04:42Zurn:sha1:b6233d0ded3391a33bb0047edafe15169131eadb
There is no more reason to check the return value of
check_symbol_range().
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: move ignored symbol types to is_ignored_symbol()2019-11-25T12:06:14ZMasahiro Yamadayamada.masahiro@socionext.com2019-11-23T16:04:41Zurn:sha1:887df76de67f5a6dd423e5763c22ff07f0e50048
Collect the ignored patterns to is_ignored_symbol().
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: move more patterns to the ignored_prefixes array2019-11-25T12:06:01ZMasahiro Yamadayamada.masahiro@socionext.com2019-11-23T16:04:40Zurn:sha1:97261e1e2240f627e27e93f7e410be1a7c97c80a
Refactoring for shortening the code.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: skip ignored symbols very early2019-11-25T12:04:57ZMasahiro Yamadayamada.masahiro@socionext.com2019-11-23T16:04:39Zurn:sha1:a41333e06acd1b37f3a3248fb90cd417218f9439
Unless the address range matters, symbols can be ignored earlier,
which avoids unneeded memory allocation.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: add const qualifiers where possible2019-11-25T12:04:33ZMasahiro Yamadayamada.masahiro@socionext.com2019-11-23T16:04:38Zurn:sha1:4bfe2b7816a6e97fba7b4125166b33db4b31d29d
Add 'const' where a function does not write to the pointer dereferenes.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: make find_token() return (unsigned char *)2019-11-25T12:04:11ZMasahiro Yamadayamada.masahiro@socionext.com2019-11-23T16:04:37Zurn:sha1:2558c138aca75e5fc435e20fd37f0b0eea61bb65
The callers of this function expect (unsigned char *). I do not see
a good reason to make this function return (void *).
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: replace prefix_underscores_count() with strspn()2019-11-25T12:03:51ZMasahiro Yamadayamada.masahiro@socionext.com2019-11-23T16:04:36Zurn:sha1:aa915245005bdb45ccbc96964853b4a27646390f
You can do equivalent things with strspn(). I do not see noticeable
performance difference.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>