diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2023-01-21 16:54:03 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2023-02-08 07:56:05 +0100 |
| commit | 2e18e118c22594cced8121e6ab7ca27a60bcfc29 (patch) | |
| tree | 075f6e58ab326395d97ce54298e786307d42dcf1 /tools/perf/scripts/python/bin/stackcollapse-report | |
| parent | media: atomisp: Only set default_run_mode on first open of a stream/asd (diff) | |
| download | linux-2e18e118c22594cced8121e6ab7ca27a60bcfc29.tar.gz linux-2e18e118c22594cced8121e6ab7ca27a60bcfc29.zip | |
media: atomisp: Fix WARN() when the vb2 start_streaming callback fails
The videobuf2-core expects buffers to be put back in the queued state
when the vb2 start_streaming callback fails. But the atomisp
atomisp_flush_video_pipe() would unconditionally return them to the core
in an error state.
This triggers the following warning in the videobuf2-core:
drivers/media/common/videobuf2/videobuf2-core.c:1652:
/*
* If done_list is not empty, then start_streaming() didn't call
* vb2_buffer_done(vb, VB2_BUF_STATE_QUEUED) but STATE_ERROR or
* STATE_DONE.
*/
WARN_ON(!list_empty(&q->done_list));
Fix this by adding a state argument to atomisp_flush_video_pipe() and use
VB2_BUF_STATE_QUEUED as state when atomisp_start_streaming() fails.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/bin/stackcollapse-report')
0 files changed, 0 insertions, 0 deletions