diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-06-14 08:49:45 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-06-14 10:26:32 -0700 |
| commit | 129cb1b99df46771889c6d432055be4edd2b81b9 (patch) | |
| tree | 76d79aac7c974374265195d9844cc21f9792c659 | |
| parent | Merge branch 'gt/unit-test-oidtree' into ps/use-the-repository (diff) | |
| download | git-129cb1b99df46771889c6d432055be4edd2b81b9.tar.gz git-129cb1b99df46771889c6d432055be4edd2b81b9.zip | |
hash: drop (mostly) unused `is_empty_{blob,tree}_sha1()` functions
The functions `is_empty_{blob,tree}_sha1()` are mostly unused, except
for a single callsite in "read-cache.c". Most callsites have long since
been converted to use the equivalents that accept a `struct object_id`
instead of a string.
Adapt the remaining callsite and drop those functions.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | hash.h | 10 | ||||
| -rw-r--r-- | read-cache.c | 2 |
2 files changed, 1 insertions, 11 deletions
@@ -84,21 +84,11 @@ static inline void oidread(struct object_id *oid, const unsigned char *hash) oidread_algop(oid, hash, the_hash_algo); } -static inline int is_empty_blob_sha1(const unsigned char *sha1) -{ - return hasheq(sha1, the_hash_algo->empty_blob->hash); -} - static inline int is_empty_blob_oid(const struct object_id *oid) { return oideq(oid, the_hash_algo->empty_blob); } -static inline int is_empty_tree_sha1(const unsigned char *sha1) -{ - return hasheq(sha1, the_hash_algo->empty_tree->hash); -} - static inline int is_empty_tree_oid(const struct object_id *oid) { return oideq(oid, the_hash_algo->empty_tree); diff --git a/read-cache.c b/read-cache.c index 447109aa76..10e002ce6d 100644 --- a/read-cache.c +++ b/read-cache.c @@ -337,7 +337,7 @@ static int ce_match_stat_basic(const struct cache_entry *ce, struct stat *st) /* Racily smudged entry? */ if (!ce->ce_stat_data.sd_size) { - if (!is_empty_blob_sha1(ce->oid.hash)) + if (!is_empty_blob_oid(&ce->oid)) changed |= DATA_CHANGED; } |
