diff options
| author | Patrick Steinhardt <ps@pks.im> | 2026-04-21 09:34:24 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-04-22 15:53:36 -0700 |
| commit | 1ecf6538263cf81c151f2e720cd73fde3d50a07e (patch) | |
| tree | b1d536d77e3e117af0a7cecfcf3655c3ea153936 | |
| parent | 090af9957c14915461f302f422d2c147b3e9175b (diff) | |
| download | git-1ecf6538263cf81c151f2e720cd73fde3d50a07e.tar.gz git-1ecf6538263cf81c151f2e720cd73fde3d50a07e.zip | |
t9902: fix use of `read` with `set -e`
In t9902 we're using the `read` builtin to read some values into a
variable. This is done by using `-d ""`, which cause us to read until
the end of the heredoc. As the read is terminated by EOF, the command
will end up returning a non-zero error code. This hasn't been an issue
until now as we didn't run with `set -e`, but that'll change in a
subsequent commit.
Prepare for this change by not using read at all, as we can simply store
the multi-line value directly.
Suggested-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t9902-completion.sh | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index 2f9a597ec7..28f61f08fb 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh @@ -590,12 +590,10 @@ test_expect_success '__gitcomp - doesnt fail because of invalid variable name' ' __gitcomp "$invalid_variable_name" ' -read -r -d "" refs <<-\EOF -main +refs='main maint next -seen -EOF +seen' test_expect_success '__gitcomp_nl - trailing space' ' test_gitcomp_nl "m" "$refs" <<-EOF |