aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorElijah Newren <newren@gmail.com>2023-12-23 17:14:56 +0000
committerJunio C Hamano <gitster@pobox.com>2023-12-26 12:04:32 -0800
commit545f7b50e8c7c63c3e763519f64846624dce6d52 (patch)
treec55b33cbce4a45e8d4b393d569a8d31660e768a4
parentline-log.h: remove unnecessary include (diff)
downloadgit-545f7b50e8c7c63c3e763519f64846624dce6d52.tar.gz
git-545f7b50e8c7c63c3e763519f64846624dce6d52.zip
pkt-line.h: remove unnecessary include
The unnecessary include in the header transitively pulled in some other headers actually needed by source files, though. Have those source files explicitly include the headers they need. Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--pkt-line.c1
-rw-r--r--pkt-line.h1
-rw-r--r--t/helper/test-pkt-line.c1
3 files changed, 2 insertions, 1 deletions
diff --git a/pkt-line.c b/pkt-line.c
index af83a19f4d..236dd3a3ee 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -4,6 +4,7 @@
#include "gettext.h"
#include "hex.h"
#include "run-command.h"
+#include "sideband.h"
#include "trace.h"
#include "write-or-die.h"
diff --git a/pkt-line.h b/pkt-line.h
index 954eec8719..aedef56286 100644
--- a/pkt-line.h
+++ b/pkt-line.h
@@ -2,7 +2,6 @@
#define PKTLINE_H
#include "strbuf.h"
-#include "sideband.h"
/*
* Write a packetized stream, where each line is preceded by
diff --git a/t/helper/test-pkt-line.c b/t/helper/test-pkt-line.c
index f4d134a145..77e99c37df 100644
--- a/t/helper/test-pkt-line.c
+++ b/t/helper/test-pkt-line.c
@@ -1,6 +1,7 @@
#include "git-compat-util.h"
#include "test-tool.h"
#include "pkt-line.h"
+#include "sideband.h"
#include "write-or-die.h"
static void pack_line(const char *line)