diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-08-01 12:41:15 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-08-01 08:47:38 -0700 |
| commit | f30bfafcd41d0f13575361957dc361aa2be4d4c5 (patch) | |
| tree | 4081e9ce08ca87d8fb4f58cfe15ce00ac8548274 | |
| parent | convert: fix leaking config strings (diff) | |
| download | git-f30bfafcd41d0f13575361957dc361aa2be4d4c5.tar.gz git-f30bfafcd41d0f13575361957dc361aa2be4d4c5.zip | |
commit-reach: fix trivial memory leak when computing reachability
We don't free the local `stack` commit list that we use to compute
reachability of multiple commits at once. Do so.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | commit-reach.c | 1 | ||||
| -rwxr-xr-x | t/t3201-branch-contains.sh | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/commit-reach.c b/commit-reach.c index dabc2972e4..02f8218b8e 100644 --- a/commit-reach.c +++ b/commit-reach.c @@ -1227,4 +1227,5 @@ void tips_reachable_from_bases(struct repository *r, done: free(commits); repo_clear_commit_marks(r, SEEN); + free_commit_list(stack); } diff --git a/t/t3201-branch-contains.sh b/t/t3201-branch-contains.sh index 800fc33165..6e587d27d7 100755 --- a/t/t3201-branch-contains.sh +++ b/t/t3201-branch-contains.sh @@ -2,6 +2,7 @@ test_description='branch --contains <commit>, --no-contains <commit> --merged, and --no-merged' +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh test_expect_success setup ' |