diff options
| author | Patrick Steinhardt <ps@pks.im> | 2023-05-17 13:48:46 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-05-17 09:55:33 -0700 |
| commit | 6bc7a37e79876092b42a89156a8c24d0a60bd672 (patch) | |
| tree | b0fe7e0d81f7bf5e3a28683dc7c97de19a27570e /builtin/fetch.c | |
| parent | fetch: drop unused DISPLAY_FORMAT_UNKNOWN enum value (diff) | |
| download | git-6bc7a37e79876092b42a89156a8c24d0a60bd672.tar.gz git-6bc7a37e79876092b42a89156a8c24d0a60bd672.zip | |
fetch: drop unneeded NULL-check for `remote_ref`
Drop the `NULL` check for `remote_ref` in `update_local_ref()`. The
function only has a single caller, and that caller always passes in a
non-`NULL` value.
This fixes a false positive in Coverity.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/fetch.c')
| -rw-r--r-- | builtin/fetch.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/builtin/fetch.c b/builtin/fetch.c index 9147b700e5..f268322e6f 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -953,11 +953,10 @@ static int update_local_ref(struct ref *ref, * Base this on the remote's ref name, as it's * more likely to follow a standard layout. */ - const char *name = remote_ref ? remote_ref->name : ""; - if (starts_with(name, "refs/tags/")) { + if (starts_with(remote_ref->name, "refs/tags/")) { msg = "storing tag"; what = _("[new tag]"); - } else if (starts_with(name, "refs/heads/")) { + } else if (starts_with(remote_ref->name, "refs/heads/")) { msg = "storing head"; what = _("[new branch]"); } else { |