diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-05-27 13:46:06 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-05-27 11:19:58 -0700 |
| commit | cc395d6b47e4af59b3e87a64b34dffa79e8dc262 (patch) | |
| tree | b1e71b4797f89fe945f2ee87860ee24bcefa37be /checkout.h | |
| parent | strbuf: fix leak when `appendwholeline()` fails with EOF (diff) | |
| download | git-cc395d6b47e4af59b3e87a64b34dffa79e8dc262.tar.gz git-cc395d6b47e4af59b3e87a64b34dffa79e8dc262.zip | |
checkout: clarify memory ownership in `unique_tracking_name()`
The function `unique_tracking_name()` returns an allocated string, but
does not clearly indicate this because its return type is `const char *`
instead of `char *`. This has led to various callsites where we never
free its returned memory at all, which causes memory leaks.
Plug those leaks and mark now-passing tests as leak free.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'checkout.h')
| -rw-r--r-- | checkout.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/checkout.h b/checkout.h index 3c514a5ab4..ba15a13fb3 100644 --- a/checkout.h +++ b/checkout.h @@ -8,8 +8,8 @@ * tracking branch. Return the name of the remote if such a branch * exists, NULL otherwise. */ -const char *unique_tracking_name(const char *name, - struct object_id *oid, - int *dwim_remotes_matched); +char *unique_tracking_name(const char *name, + struct object_id *oid, + int *dwim_remotes_matched); #endif /* CHECKOUT_H */ |